[net-next,v2,0/4] Remove legacy phylink behaviour

Message

Russell King (Oracle) July 22, 2023, 8:29 p.m. UTC

Hi,

This series removes the - as far as I can tell - unreachable code in
mtk_eth_soc that relies upon legacy phylink behaviour, and then removes
the support in phylink for this legacy behaviour.

Patch 1 removes the clocking configuration from mtk_eth_soc for non-
TRGMII, non-serdes based interface modes, and disables those interface
modes prior to phylink configuration.

Patch 2 removes the mac_pcs_get_state() method from mtk_eth_soc which
I believe is also not used - mtk_eth_soc appears not to be used with
SFPs (which would use a kind of in-band mode) nor does any DT appear
to specify in-band mode for any non-serdes based interface mode.

With both of those dealt with, the kernel is now free of any driver
relying on the phylink legacy mode. Therefore, patch 3 removes support
for this.

Finally, with the advent of a new driver being submitted today that
makes use of state->speed in the mac_config() path, patch 4 ensures that
any phylink_link_state member that should not be used in mac_config is
either cleared or set to an invalid value.

v2: rebase on net-next, add attributations for testing etc

 drivers/net/ethernet/mediatek/mtk_eth_soc.c | 94 +++++------------------------
 drivers/net/ethernet/mediatek/mtk_eth_soc.h |  1 +
 drivers/net/phy/phylink.c                   | 48 ++++++---------
 include/linux/phylink.h                     | 45 ++------------
 4 files changed, 42 insertions(+), 146 deletions(-)

Comments

[e-mail] July 25, 2023, 1:10 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by Paolo Abeni <[e-mail]>:

On Sat, 22 Jul 2023 21:29:02 +0100 you wrote:
> Hi,
> 
> This series removes the - as far as I can tell - unreachable code in
> mtk_eth_soc that relies upon legacy phylink behaviour, and then removes
> the support in phylink for this legacy behaviour.
> 
> Patch 1 removes the clocking configuration from mtk_eth_soc for non-
> TRGMII, non-serdes based interface modes, and disables those interface
> modes prior to phylink configuration.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/4] net: ethernet: mtk_eth_soc: remove incorrect PLL configuration
    https://git.kernel.org/netdev/net-next/c/76a4cb755cf9
  - [net-next,v2,2/4] net: ethernet: mtk_eth_soc: remove mac_pcs_get_state and modernise
    https://git.kernel.org/netdev/net-next/c/28e1737d2544
  - [net-next,v2,3/4] net: phylink: strip out pre-March 2020 legacy code
    https://git.kernel.org/netdev/net-next/c/4d72c3bb60dd
  - [net-next,v2,4/4] net: phylink: explicitly invalidate link_state members in mac_config
    https://git.kernel.org/netdev/net-next/c/c5714f68a76b

You are awesome, thank you!