| Message ID | Zlbp7xdUZAXblOZJ@shell.armlinux.org.uk (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: stmmac: cleanups | expand |
Hi Russell On Wed, May 29, 2024 at 09:40:15AM +0100, Russell King (Oracle) wrote: > Hi, > > This series removes various redundant items in the stmmac driver: > > - the unused TBI and RTBI PCS flags > - the NULL pointer initialisations for PCS methods in dwxgmac2 > - the stmmac_pcs_rane() method which is never called, and it's > associated implementations > - the redundant netif_carrier_off()s > > Finally, it replaces asm/io.h with the preferred linux/io.h. > > Changes since v1: > - Fix patch 1 "Drop TBI/RTBI flags" which didn't transfer correctly > between my internal trees! > - Update patch 5 to address all the asm/io.h in stmmac > - Add Andrew Halaney's reviewed-by > - Add patch 6 cleaning up qcom-ethqos phy speed setting Thanks for the series. For all patches: Reviewed-by: Serge Semin <fancer.lancer@gmail.com> * Note I've got your messages regarding the STMMAC driver and RGMII/SGMII/etc PCS. I do remember about that and will respond to all of them either later today or tomorrow. Currently busy with my long lasting DW XPCS series. -Serge(y) > > drivers/net/ethernet/stmicro/stmmac/common.h | 2 -- > .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 24 +++++++------- > .../net/ethernet/stmicro/stmmac/dwmac1000_core.c | 8 +---- > .../net/ethernet/stmicro/stmmac/dwmac1000_dma.c | 2 +- > .../net/ethernet/stmicro/stmmac/dwmac100_core.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac100_dma.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 8 ----- > .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 6 ---- > drivers/net/ethernet/stmicro/stmmac/hwif.h | 3 -- > .../net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 38 +++++----------------- > drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h | 17 ---------- > 12 files changed, 26 insertions(+), 88 deletions(-) > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 29 May 2024 09:40:15 +0100 you wrote: > Hi, > > This series removes various redundant items in the stmmac driver: > > - the unused TBI and RTBI PCS flags > - the NULL pointer initialisations for PCS methods in dwxgmac2 > - the stmmac_pcs_rane() method which is never called, and it's > associated implementations > - the redundant netif_carrier_off()s > > [...] Here is the summary with links: - [net-next,v2,1/6] net: stmmac: Drop TBI/RTBI PCS flags https://git.kernel.org/netdev/net-next/c/482b3c3ba757 - [net-next,v2,2/6] net: stmmac: dwxgmac2: remove useless NULL pointer initialisations https://git.kernel.org/netdev/net-next/c/4af90c0f4844 - [net-next,v2,3/6] net: stmmac: remove pcs_rane() method https://git.kernel.org/netdev/net-next/c/3277407e5e82 - [net-next,v2,4/6] net: stmmac: remove unnecessary netif_carrier_off() https://git.kernel.org/netdev/net-next/c/aee04f4bb44d - [net-next,v2,5/6] net: stmmac: include linux/io.h rather than asm/io.h https://git.kernel.org/netdev/net-next/c/cd56ff75ccfc - [net-next,v2,6/6] net: stmmac: ethqos: clean up setting serdes speed https://git.kernel.org/netdev/net-next/c/7efc70657704 You are awesome, thank you!