mbox series

[net-next,0/3] Removing more phylink cruft

Message ID ZwVEjCFsrxYuaJGz@shell.armlinux.org.uk (mailing list archive)
Headers show
Series Removing more phylink cruft | expand

Message

Russell King (Oracle) Oct. 8, 2024, 2:41 p.m. UTC
Hi,

Continuing on with the cleanups, this patch series removes
dsa_port_phylink_mac_select_pcs() which is no longer required. This
will have no functional effect as phylink does this:

        bool using_mac_select_pcs = false;

        if (mac_ops->mac_select_pcs &&
            mac_ops->mac_select_pcs(config, PHY_INTERFACE_MODE_NA) !=
              ERR_PTR(-EOPNOTSUPP))
                using_mac_select_pcs = true;

and no mac_select_pcs() method is equivalent to a mac_select_pcs()
that returns -EOPNOTSUPP.

We then make mv88e6xxx_mac_select_pcs() return NULL, as we don't
want to invoke this old behaviour anymore - mv88e6xxx doesn't require
it.

This then clears the way to removing using_mac_select_pcs from phylink
and the check.

 drivers/net/dsa/mv88e6xxx/chip.c |  2 +-
 drivers/net/phy/phylink.c        | 14 +++-----------
 net/dsa/port.c                   |  8 --------
 3 files changed, 4 insertions(+), 20 deletions(-)