| Message ID | ZxeO2oJeQcH5H55X@shell.armlinux.org.uk (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: phylink: simplify SFP PHY attachment | expand |
Hello Russell, On Tue, 22 Oct 2024 12:39:06 +0100 "Russell King (Oracle)" <linux@armlinux.org.uk> wrote: > Hi, > > These two patches simplify how we attach SFP PHYs. > > The first patch notices that at the two sites where we call > sfp_select_interface(), if that fails, we always print the same error. > Move this into its own function. > > The second patch adds an additional level of validation, checking that > the returned interface is one that is supported by the MAC/PCS. > > The last patch simplifies how SFP PHYs are attached, reducing the > number of times that we do validation in this path. > > drivers/net/phy/phylink.c | 82 ++++++++++++++++++++++++----------------------- > 1 file changed, 42 insertions(+), 40 deletions(-) It looks like the patches didn't make it through, there're also not on lore nor patchwork :( Maxime
On Tue, Oct 22, 2024 at 01:54:47PM +0200, Maxime Chevallier wrote: > Hello Russell, > > On Tue, 22 Oct 2024 12:39:06 +0100 > "Russell King (Oracle)" <linux@armlinux.org.uk> wrote: > > > Hi, > > > > These two patches simplify how we attach SFP PHYs. > > > > The first patch notices that at the two sites where we call > > sfp_select_interface(), if that fails, we always print the same error. > > Move this into its own function. > > > > The second patch adds an additional level of validation, checking that > > the returned interface is one that is supported by the MAC/PCS. > > > > The last patch simplifies how SFP PHYs are attached, reducing the > > number of times that we do validation in this path. > > > > drivers/net/phy/phylink.c | 82 ++++++++++++++++++++++++----------------------- > > 1 file changed, 42 insertions(+), 40 deletions(-) > > It looks like the patches didn't make it through, there're also not on > lore nor patchwork :( You're too quick. I was delaying the patches for two reasons: 1) to ensure Jakub's nipa bot bug doesn't get me again. 2) build-testing the series, as I'd made a change... and unsurprisingly not waiting for that to finish, and sending the patches, immediately after sending it found a problem. :(