[V3,net-next,0/5] add support for RFC 8335 PROBE

Message

Andreas Roeseler Feb. 17, 2021, 6:07 p.m. UTC

The popular utility ping has several severe limitations such as the
inability to query specific interfaces on a node and requiring
bidirectional connectivity between the probing and probed interfaces.
RFC 8335 attempts to solve these limitations by creating the new utility
PROBE which is a specialized ICMP message that makes use of the ICMP
Extention Structure outlined in RFC 4884.

This patchset adds definitions for the ICMP Extended Echo Request and
Reply (PROBE) types for both IPV4 and IPV6, adds a sysctl to enable 
response to PROBE messages, expands the list of supported ICMP messages
to accommodate PROBE types, and adds functionality to respond to PROBE
requests.

Changes since v1:
 - Add AFI definitions
 - Switch to functions such as dev_get_by_name and ip_dev_find to lookup
   net devices 

Changes since v2:
Suggested by Willem de Brujin <[e-mail]>
 - Add verification of incoming messages before looking up netdev
 - Add prefix for PROBE specific defined variables
 - Use proc_dointvec_minmax with zero and one  
 - Create struct icmp_ext_echo_iio for parsing incoming packet
Reported-by: kernel test robot <[e-mail]>
Reported-by: Dan Carpenter <[e-mail]>
 - Include net/addrconf.h library for ipv6_dev_find

Andreas Roeseler (5):
  icmp: add support for RFC 8335 PROBE
  ICMPV6: add support for RFC 8335 PROBE
  net: add sysctl for enabling RFC 8335 PROBE messages
  net: add support for sending RFC 8335 PROBE messages
  icmp: add response to RFC 8335 PROBE messages

 include/net/netns/ipv4.h    |   1 +
 include/uapi/linux/icmp.h   |  40 +++++++++++
 include/uapi/linux/icmpv6.h |   6 ++
 net/ipv4/icmp.c             | 133 +++++++++++++++++++++++++++++++++---
 net/ipv4/ping.c             |   4 +-
 net/ipv4/sysctl_net_ipv4.c  |   9 +++
 6 files changed, 181 insertions(+), 12 deletions(-)

Comments

David Miller Feb. 17, 2021, 10:25 p.m. UTC | #1

From: Andreas Roeseler <[e-mail]>
Date: Wed, 17 Feb 2021 10:07:38 -0800

> The popular utility ping has several severe limitations such as the
> inability to query specific interfaces on a node and requiring
> bidirectional connectivity between the probing and probed interfaces.
> RFC 8335 attempts to solve these limitations by creating the new utility
> PROBE which is a specialized ICMP message that makes use of the ICMP
> Extention Structure outlined in RFC 4884.
> 
> This patchset adds definitions for the ICMP Extended Echo Request and
> Reply (PROBE) types for both IPV4 and IPV6, adds a sysctl to enable 
> response to PROBE messages, expands the list of supported ICMP messages
> to accommodate PROBE types, and adds functionality to respond to PROBE
> requests.
> 
> Changes since v1:
>  - Add AFI definitions
>  - Switch to functions such as dev_get_by_name and ip_dev_find to lookup
>    net devices 
> 
> Changes since v2:
> Suggested by Willem de Brujin <[e-mail]>
>  - Add verification of incoming messages before looking up netdev
>  - Add prefix for PROBE specific defined variables
>  - Use proc_dointvec_minmax with zero and one  
>  - Create struct icmp_ext_echo_iio for parsing incoming packet
> Reported-by: kernel test robot <[e-mail]>
> Reported-by: Dan Carpenter <[e-mail]>
>  - Include net/addrconf.h library for ipv6_dev_find

Thi is too late for the current merge window, sorry.  Please resubmit when net-next opens
back up, thank you.