mbox series

[v2,0/2,next] wl3501_cs: Fix out-of-bounds warnings

Message ID cover.1617226663.git.gustavoars@kernel.org (mailing list archive)
Headers show
Series wl3501_cs: Fix out-of-bounds warnings | expand

Message

Gustavo A. R. Silva March 31, 2021, 9:43 p.m. UTC 
Fix the a couple of  out-of-bounds warnings by making the code
a bit more structured.

This helps with the ongoing efforts to enable -Warray-bounds and
avoid confusing the compiler.

Link: https://github.com/KSPP/linux/issues/109

Changes in v2:
 - Update changelog text in patch 1/2.
 - Replace a couple of magic numbers with new variable sig_addr_len.

Gustavo A. R. Silva (2):
  wl3501_cs: Fix out-of-bounds warning in wl3501_send_pkt
  wl3501_cs: Fix out-of-bounds warning in wl3501_mgmt_join

 drivers/net/wireless/wl3501.h    | 28 ++++++++++++++++------------
 drivers/net/wireless/wl3501_cs.c | 11 ++++++-----
 2 files changed, 22 insertions(+), 17 deletions(-)

Comments

Gustavo A. R. Silva April 13, 2021, 9:27 p.m. UTC | #1 
Hi all,

Friendly ping: could somebody give us some feedback or take
this series, please?

Thanks
--
Gustavo

On 3/31/21 16:43, Gustavo A. R. Silva wrote:
> Fix the a couple of  out-of-bounds warnings by making the code
> a bit more structured.
> 
> This helps with the ongoing efforts to enable -Warray-bounds and
> avoid confusing the compiler.
> 
> Link: https://github.com/KSPP/linux/issues/109
> 
> Changes in v2:
>  - Update changelog text in patch 1/2.
>  - Replace a couple of magic numbers with new variable sig_addr_len.
> 
> Gustavo A. R. Silva (2):
>   wl3501_cs: Fix out-of-bounds warning in wl3501_send_pkt
>   wl3501_cs: Fix out-of-bounds warning in wl3501_mgmt_join
> 
>  drivers/net/wireless/wl3501.h    | 28 ++++++++++++++++------------
>  drivers/net/wireless/wl3501_cs.c | 11 ++++++-----
>  2 files changed, 22 insertions(+), 17 deletions(-)
>
Kalle Valo April 14, 2021, 6:51 a.m. UTC | #2 
"Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:

> Friendly ping: could somebody give us some feedback or take
> this series, please?

First patch 2 comment needs to be resolved.
Gustavo A. R. Silva April 15, 2021, midnight UTC | #3 
On 4/14/21 01:51, Kalle Valo wrote:
> "Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
> 
>> Friendly ping: could somebody give us some feedback or take
>> this series, please?
> 
> First patch 2 comment needs to be resolved.

Done:

https://lore.kernel.org/lkml/cover.1618442265.git.gustavoars@kernel.org/

Thanks
--
Gustavo