| Message ID | cover.1624032669.git.paskripkin@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: ethernat: ezchip: bug fixing and code improvments | expand |
Hello: This series was applied to netdev/net.git (refs/heads/master): On Fri, 18 Jun 2021 19:14:23 +0300 you wrote: > While manual code reviewing, I found some error in ezchip driver. > Two of them looks very dangerous: > 1. use-after-free in nps_enet_remove > Accessing netdev private data after free_netdev() > > 2. wrong error handling of platform_get_irq() > It can cause passing negative irq to request_irq() > > [...] Here is the summary with links: - [1/3] net: ethernet: ezchip: fix UAF in nps_enet_remove https://git.kernel.org/netdev/net/c/e4b8700e07a8 - [2/3] net: ethernet: ezchip: remove redundant check https://git.kernel.org/netdev/net/c/4ae85b23e1f0 - [3/3] net: ethernet: ezchip: fix error handling https://git.kernel.org/netdev/net/c/0de449d59959 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
While manual code reviewing, I found some error in ezchip driver. Two of them looks very dangerous: 1. use-after-free in nps_enet_remove Accessing netdev private data after free_netdev() 2. wrong error handling of platform_get_irq() It can cause passing negative irq to request_irq() Also, in 2nd patch I removed redundant check to increase execution speed and make code more straightforward. Pavel Skripkin (3): net: ethernet: ezchip: fix UAF in nps_enet_remove net: ethernet: ezchip: remove redundant check net: ethernet: ezchip: fix error handling drivers/net/ethernet/ezchip/nps_enet.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)