| Message ID | cover.1641468127.git.naveen.n.rao@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | powerpc/bpf: Some fixes and updates | expand |
Hi Naveen, On 1/6/22 12:45 PM, Naveen N. Rao wrote: > A set of fixes and updates to powerpc BPF JIT: > - Patches 1-3 fix issues with the existing powerpc JIT and are tagged > for -stable. > - Patch 4 fixes a build issue with bpf selftests on powerpc. > - Patches 5-9 handle some corner cases and make some small improvements. > - Patches 10-13 optimize how function calls are handled in ppc64. > > Patches 7 and 8 were previously posted, and while patch 7 has no > changes, patch 8 has been reworked to handle BPF_EXIT differently. Is the plan to route these via ppc trees? Fwiw, patch 1 and 4 look generic and in general good to me, we could also take these two via bpf-next tree given outside of arch/powerpc/? Whichever works best. Thanks, Daniel
Hi Daniel, Daniel Borkmann wrote: > Hi Naveen, > > On 1/6/22 12:45 PM, Naveen N. Rao wrote: >> A set of fixes and updates to powerpc BPF JIT: >> - Patches 1-3 fix issues with the existing powerpc JIT and are tagged >> for -stable. >> - Patch 4 fixes a build issue with bpf selftests on powerpc. >> - Patches 5-9 handle some corner cases and make some small improvements. >> - Patches 10-13 optimize how function calls are handled in ppc64. >> >> Patches 7 and 8 were previously posted, and while patch 7 has no >> changes, patch 8 has been reworked to handle BPF_EXIT differently. > > Is the plan to route these via ppc trees? Fwiw, patch 1 and 4 look generic > and in general good to me, we could also take these two via bpf-next tree > given outside of arch/powerpc/? Whichever works best. Yes, I would like to route this through the powerpc tree. Though patches 1 and 4 are generic, they primarily affect powerpc and I do not see conflicting changes in bpf-next. Request you to please ack those patches so that Michael can take it through the powerpc tree. Thanks! - Naveen
On 1/7/22 8:36 AM, Naveen N. Rao wrote: > Daniel Borkmann wrote: >> On 1/6/22 12:45 PM, Naveen N. Rao wrote: >>> A set of fixes and updates to powerpc BPF JIT: >>> - Patches 1-3 fix issues with the existing powerpc JIT and are tagged >>> for -stable. >>> - Patch 4 fixes a build issue with bpf selftests on powerpc. >>> - Patches 5-9 handle some corner cases and make some small improvements. >>> - Patches 10-13 optimize how function calls are handled in ppc64. >>> >>> Patches 7 and 8 were previously posted, and while patch 7 has no >>> changes, patch 8 has been reworked to handle BPF_EXIT differently. >> >> Is the plan to route these via ppc trees? Fwiw, patch 1 and 4 look generic >> and in general good to me, we could also take these two via bpf-next tree >> given outside of arch/powerpc/? Whichever works best. > > Yes, I would like to route this through the powerpc tree. Though patches 1 and 4 are generic, they primarily affect powerpc and I do not see conflicting changes in bpf-next. Request you to please ack those patches so that Michael can take it through the powerpc tree. Ok, works for me. I presume this will end up in the upcoming merge window anyway, so not too long time until we can sync these back to bpf/bpf-next trees then. Thanks! Daniel
Daniel Borkmann <daniel@iogearbox.net> writes: > On 1/7/22 8:36 AM, Naveen N. Rao wrote: >> Daniel Borkmann wrote: >>> On 1/6/22 12:45 PM, Naveen N. Rao wrote: >>>> A set of fixes and updates to powerpc BPF JIT: >>>> - Patches 1-3 fix issues with the existing powerpc JIT and are tagged >>>> for -stable. >>>> - Patch 4 fixes a build issue with bpf selftests on powerpc. >>>> - Patches 5-9 handle some corner cases and make some small improvements. >>>> - Patches 10-13 optimize how function calls are handled in ppc64. >>>> >>>> Patches 7 and 8 were previously posted, and while patch 7 has no >>>> changes, patch 8 has been reworked to handle BPF_EXIT differently. >>> >>> Is the plan to route these via ppc trees? Fwiw, patch 1 and 4 look generic >>> and in general good to me, we could also take these two via bpf-next tree >>> given outside of arch/powerpc/? Whichever works best. >> >> Yes, I would like to route this through the powerpc tree. Though patches 1 and 4 are generic, they primarily affect powerpc and I do not see conflicting changes in bpf-next. Request you to please ack those patches so that Michael can take it through the powerpc tree. > > Ok, works for me. I presume this will end up in the upcoming merge window > anyway, so not too long time until we can sync these back to bpf/bpf-next > trees then. Hmm. This series landed a little late for me to get it into linux-next before the merge window opened. It's mostly small and includes some bug fixes, so I'm not saying it needs to wait for the next merge window, but I would like it to get some testing in linux-next before I ask Linus to pull it. When would you need it all merged into Linus' tree in order to sync up with the bpf tree for the next cycle? I assume as long as it's merged before rc1 that would be sufficient? cheers
On Thu, 6 Jan 2022 17:15:04 +0530, Naveen N. Rao wrote: > A set of fixes and updates to powerpc BPF JIT: > - Patches 1-3 fix issues with the existing powerpc JIT and are tagged > for -stable. > - Patch 4 fixes a build issue with bpf selftests on powerpc. > - Patches 5-9 handle some corner cases and make some small improvements. > - Patches 10-13 optimize how function calls are handled in ppc64. > > [...] Patches 1-4, and 8 applied to powerpc/fixes. [01/13] bpf: Guard against accessing NULL pt_regs in bpf_get_task_stack() https://git.kernel.org/powerpc/c/b992f01e66150fc5e90be4a96f5eb8e634c8249e [02/13] powerpc32/bpf: Fix codegen for bpf-to-bpf calls https://git.kernel.org/powerpc/c/fab07611fb2e6a15fac05c4583045ca5582fd826 [03/13] powerpc/bpf: Update ldimm64 instructions during extra pass https://git.kernel.org/powerpc/c/f9320c49993ca3c0ec0f9a7026b313735306bb8b [04/13] tools/bpf: Rename 'struct event' to avoid naming conflict https://git.kernel.org/powerpc/c/88a71086c48ae98e93c0208044827621e9717f7e [08/13] powerpc64/bpf: Limit 'ldbrx' to processors compliant with ISA v2.06 https://git.kernel.org/powerpc/c/3f5f766d5f7f95a69a630da3544a1a0cee1cdddf cheers
A set of fixes and updates to powerpc BPF JIT: - Patches 1-3 fix issues with the existing powerpc JIT and are tagged for -stable. - Patch 4 fixes a build issue with bpf selftests on powerpc. - Patches 5-9 handle some corner cases and make some small improvements. - Patches 10-13 optimize how function calls are handled in ppc64. Patches 7 and 8 were previously posted, and while patch 7 has no changes, patch 8 has been reworked to handle BPF_EXIT differently. - Naveen Naveen N. Rao (13): bpf: Guard against accessing NULL pt_regs in bpf_get_task_stack() powerpc32/bpf: Fix codegen for bpf-to-bpf calls powerpc/bpf: Update ldimm64 instructions during extra pass tools/bpf: Rename 'struct event' to avoid naming conflict powerpc/bpf: Skip branch range validation during first pass powerpc/bpf: Emit a single branch instruction for known short branch ranges powerpc/bpf: Handle large branch ranges with BPF_EXIT powerpc64/bpf: Limit 'ldbrx' to processors compliant with ISA v2.06 powerpc64/bpf: Do not save/restore LR on each call to bpf_stf_barrier() powerpc64/bpf: Use r12 for constant blinding powerpc64/bpf elfv2: Setup kernel TOC in r2 on entry powerpc64/bpf elfv1: Do not load TOC before calling functions powerpc64/bpf: Optimize instruction sequence used for function calls arch/powerpc/include/asm/ppc-opcode.h | 1 + arch/powerpc/net/bpf_jit.h | 8 +- arch/powerpc/net/bpf_jit64.h | 2 +- arch/powerpc/net/bpf_jit_comp.c | 55 ++++++++++-- arch/powerpc/net/bpf_jit_comp32.c | 32 +++++-- arch/powerpc/net/bpf_jit_comp64.c | 124 ++++++++++++++------------ kernel/bpf/stackmap.c | 5 +- tools/bpf/runqslower/runqslower.bpf.c | 2 +- tools/bpf/runqslower/runqslower.c | 2 +- tools/bpf/runqslower/runqslower.h | 2 +- 10 files changed, 153 insertions(+), 80 deletions(-) base-commit: bdcf18e133f656b2c97390a594fc95e37849e682