[v3,bpf-next,0/3] introduce xdp frags support to veth driver

Message

Lorenzo Bianconi Feb. 22, 2022, 7:43 p.m. UTC

Introduce xdp frags support to veth driver in order to allow increasing the mtu
over the page boundary if the attached xdp program declares to support xdp
fragments. Enable NETIF_F_ALL_TSO when the device is running in xdp mode.
This series has been tested running xdp_router_ipv4 sample available in the
kernel tree redirecting tcp traffic from veth pair into the mvneta driver.

Changes since v2:
- move rcu_access_pointer() check in veth_skb_is_eligible_for_gro

Changes since v1:
- always consider skb paged are non-writable
- fix tpt issue with sctp
- always use napi if we are running in xdp mode in veth_xmit

Lorenzo Bianconi (3):
  net: veth: account total xdp_frame len running ndo_xdp_xmit
  veth: rework veth_xdp_rcv_skb in order to accept non-linear skb
  veth: allow jumbo frames in xdp mode

 drivers/net/veth.c | 212 +++++++++++++++++++++++++++++----------------
 include/net/xdp.h  |  14 +++
 net/core/xdp.c     |   1 +
 3 files changed, 151 insertions(+), 76 deletions(-)

Comments

Lorenzo Bianconi March 8, 2022, 3:54 p.m. UTC | #1

> Introduce xdp frags support to veth driver in order to allow increasing the mtu
> over the page boundary if the attached xdp program declares to support xdp
> fragments. Enable NETIF_F_ALL_TSO when the device is running in xdp mode.
> This series has been tested running xdp_router_ipv4 sample available in the
> kernel tree redirecting tcp traffic from veth pair into the mvneta driver.

Hi Alexei and Daniel,

please drop this revision, I will post a new version soon adding a check on max
supported mtu when the loaded program support xdp frags.

Regards,
Lorenzo

> 
> Changes since v2:
> - move rcu_access_pointer() check in veth_skb_is_eligible_for_gro
> 
> Changes since v1:
> - always consider skb paged are non-writable
> - fix tpt issue with sctp
> - always use napi if we are running in xdp mode in veth_xmit
> 
> Lorenzo Bianconi (3):
>   net: veth: account total xdp_frame len running ndo_xdp_xmit
>   veth: rework veth_xdp_rcv_skb in order to accept non-linear skb
>   veth: allow jumbo frames in xdp mode
> 
>  drivers/net/veth.c | 212 +++++++++++++++++++++++++++++----------------
>  include/net/xdp.h  |  14 +++
>  net/core/xdp.c     |   1 +
>  3 files changed, 151 insertions(+), 76 deletions(-)
> 
> -- 
> 2.35.1
>

Daniel Borkmann March 8, 2022, 3:56 p.m. UTC | #2

On 3/8/22 4:54 PM, Lorenzo Bianconi wrote:
>> Introduce xdp frags support to veth driver in order to allow increasing the mtu
>> over the page boundary if the attached xdp program declares to support xdp
>> fragments. Enable NETIF_F_ALL_TSO when the device is running in xdp mode.
>> This series has been tested running xdp_router_ipv4 sample available in the
>> kernel tree redirecting tcp traffic from veth pair into the mvneta driver.
> 
> please drop this revision, I will post a new version soon adding a check on max
> supported mtu when the loaded program support xdp frags.

Ok, thanks for the notification, Lorenzo; tossed from patchwork.