[bpf-next,v4,0/5] sleepable uprobe support

Message

Delyan Kratunov June 14, 2022, 11:10 p.m. UTC

This series implements support for sleepable uprobe programs.
Key work is in patches 2 and 3, the rest is plumbing and tests.

The main observation is that the only obstacle in the way of sleepable uprobe
programs is not the uprobe infrastructure, which already runs in a user-like
context, but the rcu usage around bpf_prog_array.

Details are in patch 2 but the tl;dr is that we chain trace_tasks and normal rcu
grace periods when releasing to array to accommodate users of either rcu type.
This introduces latency for non-sleepable users (kprobe, tp) but that's deemed
acceptable, given recent benchmarks by Andrii [1]. We're a couple of orders of
magnitude under the rate of bpf_prog_array churn that would raise flags (~1MM/s per Paul).

  [1]: https://lore.kernel.org/bpf/CAEf4BzbpjN6ca7D9KOTiFPOoBYkciYvTz0UJNp5c-_3ptm=[e-mail]/

v3 -> v4:
 * Fix kdoc and inline issues
 * Rebase

v2 -> v3:
 * Inline uprobe_call_bpf into trace_uprobe.c, it's just a bpf_prog_run_array_sleepable call now.
 * Do not disable preemption for uprobe non-sleepable programs.
 * Add acks.

v1 -> v2:
 * Fix lockdep annotations in bpf_prog_run_array_sleepable
 * Chain rcu grace periods only for perf_event-attached programs. This limits
   the additional latency on the free path to use cases where we know it won't
   be a problem.
 * Add tests calling helpers only available in sleepable programs.
 * Remove kprobe.s support from libbpf.

Delyan Kratunov (5):
  bpf: move bpf_prog to bpf.h
  bpf: implement sleepable uprobes by chaining gps
  bpf: allow sleepable uprobe programs to attach
  libbpf: add support for sleepable uprobe programs
  selftests/bpf: add tests for sleepable (uk)probes

 include/linux/bpf.h                           | 88 +++++++++++++++++++
 include/linux/filter.h                        | 34 -------
 kernel/bpf/core.c                             | 15 ++++
 kernel/bpf/verifier.c                         |  4 +-
 kernel/events/core.c                          | 16 ++--
 kernel/trace/bpf_trace.c                      |  4 +-
 kernel/trace/trace_uprobe.c                   |  5 +-
 tools/lib/bpf/libbpf.c                        |  5 +-
 .../selftests/bpf/prog_tests/attach_probe.c   | 49 ++++++++++-
 .../selftests/bpf/progs/test_attach_probe.c   | 60 +++++++++++++
 10 files changed, 231 insertions(+), 49 deletions(-)

--
2.36.1

Comments

[e-mail] June 17, 2022, 2:40 a.m. UTC | #1

Hello:

This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <[e-mail]>:

On Tue, 14 Jun 2022 23:10:45 +0000 you wrote:
> This series implements support for sleepable uprobe programs.
> Key work is in patches 2 and 3, the rest is plumbing and tests.
> 
> The main observation is that the only obstacle in the way of sleepable uprobe
> programs is not the uprobe infrastructure, which already runs in a user-like
> context, but the rcu usage around bpf_prog_array.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v4,1/5] bpf: move bpf_prog to bpf.h
    https://git.kernel.org/bpf/bpf-next/c/d687f621c518
  - [bpf-next,v4,3/5] bpf: allow sleepable uprobe programs to attach
    https://git.kernel.org/bpf/bpf-next/c/64ad7556c75e
  - [bpf-next,v4,5/5] selftests/bpf: add tests for sleepable (uk)probes
    https://git.kernel.org/bpf/bpf-next/c/cb3f4a4a462b
  - [bpf-next,v4,2/5] bpf: implement sleepable uprobes by chaining gps
    https://git.kernel.org/bpf/bpf-next/c/8c7dcb84e3b7
  - [bpf-next,v4,4/5] libbpf: add support for sleepable uprobe programs
    https://git.kernel.org/bpf/bpf-next/c/c4cac71fc8a5

You are awesome, thank you!