mbox series

[net,0/4] macsec: fix config issues

Message ID cover.1656519221.git.sd@queasysnail.net (mailing list archive)
Headers show
Series macsec: fix config issues | expand

Message

Sabrina Dubroca July 22, 2022, 9:16 a.m. UTC
The patch adding netlink support for XPN (commit 48ef50fa866a
("macsec: Netlink support of XPN cipher suites (IEEE 802.1AEbw)"))
introduced several issues, including a kernel panic reported at [1].

Reproducing those bugs with upstream iproute is limited, since iproute
doesn't currently support XPN. I'm also working on this.

[1] https://bugzilla.kernel.org/show_bug.cgi?id=208315

Sabrina Dubroca (4):
  macsec: fix NULL deref in macsec_add_rxsa
  macsec: fix error message in macsec_add_rxsa and _txsa
  macsec: limit replay window size with XPN
  macsec: always read MACSEC_SA_ATTR_PN as a u64

 drivers/net/macsec.c | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org July 25, 2022, 11 a.m. UTC | #1
Hello:

This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 22 Jul 2022 11:16:26 +0200 you wrote:
> The patch adding netlink support for XPN (commit 48ef50fa866a
> ("macsec: Netlink support of XPN cipher suites (IEEE 802.1AEbw)"))
> introduced several issues, including a kernel panic reported at [1].
> 
> Reproducing those bugs with upstream iproute is limited, since iproute
> doesn't currently support XPN. I'm also working on this.
> 
> [...]

Here is the summary with links:
  - [net,1/4] macsec: fix NULL deref in macsec_add_rxsa
    https://git.kernel.org/netdev/net/c/f46040eeaf2e
  - [net,2/4] macsec: fix error message in macsec_add_rxsa and _txsa
    https://git.kernel.org/netdev/net/c/3240eac4ff20
  - [net,3/4] macsec: limit replay window size with XPN
    https://git.kernel.org/netdev/net/c/b07a0e204405
  - [net,4/4] macsec: always read MACSEC_SA_ATTR_PN as a u64
    https://git.kernel.org/netdev/net/c/c630d1fe6219

You are awesome, thank you!