| Message ID | cover.1670005543.git.leonro@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Extend XFRM core to allow packet offload configuration | expand |
On Fri, Dec 02, 2022 at 08:41:26PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@nvidia.com> > > The following series extends XFRM core code to handle a new type of IPsec > offload - packet offload. <...> > Leon Romanovsky (8): > xfrm: add new packet offload flag > xfrm: allow state packet offload mode > xfrm: add an interface to offload policy > xfrm: add TX datapath support for IPsec packet offload mode > xfrm: add RX datapath protection for IPsec packet offload mode > xfrm: speed-up lookup of HW policies > xfrm: add support to HW update soft and hard limits > xfrm: document IPsec packet offload mode Hi Steffen, Like we discussed on v9 of this series, I do prefer to see this code merged before merge window. It will simplify so much for me, like UAPI exposure for iproute2 and *swan* forks. The internal API for our mlx5 refactoring e.t.c. The code in our regression is all time and it is completely safe for any non-packet offload devices. Thanks
On Fri, Dec 02, 2022 at 08:41:26PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@nvidia.com> ... > > Leon Romanovsky (8): > xfrm: add new packet offload flag > xfrm: allow state packet offload mode > xfrm: add an interface to offload policy > xfrm: add TX datapath support for IPsec packet offload mode > xfrm: add RX datapath protection for IPsec packet offload mode > xfrm: speed-up lookup of HW policies > xfrm: add support to HW update soft and hard limits > xfrm: document IPsec packet offload mode > > Documentation/networking/xfrm_device.rst | 62 +++++- > .../inline_crypto/ch_ipsec/chcr_ipsec.c | 4 + > .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 5 + > drivers/net/ethernet/intel/ixgbevf/ipsec.c | 5 + > .../mellanox/mlx5/core/en_accel/ipsec.c | 4 + > .../net/ethernet/netronome/nfp/crypto/ipsec.c | 5 + > drivers/net/netdevsim/ipsec.c | 5 + > include/linux/netdevice.h | 4 + > include/net/xfrm.h | 124 +++++++++--- > include/uapi/linux/xfrm.h | 6 + > net/xfrm/xfrm_device.c | 109 +++++++++- > net/xfrm/xfrm_output.c | 12 +- > net/xfrm/xfrm_policy.c | 85 +++++++- > net/xfrm/xfrm_state.c | 191 ++++++++++++++++-- > net/xfrm/xfrm_user.c | 20 ++ > 15 files changed, 577 insertions(+), 64 deletions(-) Series applied, thanks a lot Leon!
On Tue, Dec 06, 2022 at 01:47:45PM +0100, Steffen Klassert wrote: > On Fri, Dec 02, 2022 at 08:41:26PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@nvidia.com> > ... > > > > Leon Romanovsky (8): > > xfrm: add new packet offload flag > > xfrm: allow state packet offload mode > > xfrm: add an interface to offload policy > > xfrm: add TX datapath support for IPsec packet offload mode > > xfrm: add RX datapath protection for IPsec packet offload mode > > xfrm: speed-up lookup of HW policies > > xfrm: add support to HW update soft and hard limits > > xfrm: document IPsec packet offload mode > > > > Documentation/networking/xfrm_device.rst | 62 +++++- > > .../inline_crypto/ch_ipsec/chcr_ipsec.c | 4 + > > .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 5 + > > drivers/net/ethernet/intel/ixgbevf/ipsec.c | 5 + > > .../mellanox/mlx5/core/en_accel/ipsec.c | 4 + > > .../net/ethernet/netronome/nfp/crypto/ipsec.c | 5 + > > drivers/net/netdevsim/ipsec.c | 5 + > > include/linux/netdevice.h | 4 + > > include/net/xfrm.h | 124 +++++++++--- > > include/uapi/linux/xfrm.h | 6 + > > net/xfrm/xfrm_device.c | 109 +++++++++- > > net/xfrm/xfrm_output.c | 12 +- > > net/xfrm/xfrm_policy.c | 85 +++++++- > > net/xfrm/xfrm_state.c | 191 ++++++++++++++++-- > > net/xfrm/xfrm_user.c | 20 ++ > > 15 files changed, 577 insertions(+), 64 deletions(-) > > Series applied, thanks a lot Leon! Thanks a lot for your help.
From: Leon Romanovsky <leonro@nvidia.com> The following series extends XFRM core code to handle a new type of IPsec offload - packet offload. In this mode, the HW is going to be responsible for the whole data path, so both policy and state should be offloaded. IPsec packet offload is an improved version of IPsec crypto mode, In packet mode, HW is responsible to trim/add headers in addition to decrypt/encrypt. In this mode, the packet arrives to the stack as already decrypted and vice versa for TX (exits to HW as not-encrypted). Devices that implement IPsec packet offload mode offload policies too. In the RX path, it causes the situation that HW can't effectively handle mixed SW and HW priorities unless users make sure that HW offloaded policies have higher priorities. It means that we don't need to perform any search of inexact policies and/or priority checks if HW policy was discovered. In such situation, the HW will catch the packets anyway and HW can still implement inexact lookups. In case specific policy is not found, we will continue with packet lookup and check for existence of HW policies in inexact list. HW policies are added to the head of SPD to ensure fast lookup, as XFRM iterates over all policies in the loop. This simple solution allows us to achieve same benefits of separate HW/SW policies databases without over-engineering the code to iterate and manage two databases at the same path. To not over-engineer the code, HW policies are treated as SW ones and don't take into account netdev to allow reuse of the same priorities for policies databases without over-engineering the code to iterate and manage two databases at the same path. To not over-engineer the code, HW policies are treated as SW ones and don't take into account netdev to allow reuse of the same priorities for different devices. * No software fallback * Fragments are dropped, both in RX and TX * No sockets policies * Only IPsec transport mode is implemented ================================================================================ Rekeying: In order to support rekeying, as XFRM core is skipped, the HW/driver should do the following: * Count the handled packets * Raise event that limits are reached * Drop packets once hard limit is occurred. The XFRM core calls to newly introduced xfrm_dev_state_update_curlft() function in order to perform sync between device statistics and internal structures. On HW limit event, driver calls to xfrm_state_check_expire() to allow XFRM core take relevant decisions. This separation between control logic (in XFRM) and data plane allows us to packet reuse SW stack. ================================================================================ Configuration: iproute2: https://lore.kernel.org/netdev/cover.1652179360.git.leonro@nvidia.com/ Packet offload mode: ip xfrm state offload packet dev <if-name> dir <in|out> ip xfrm policy .... offload packet dev <if-name> Crypto offload mode: ip xfrm state offload crypto dev <if-name> dir <in|out> or (backward compatibility) ip xfrm state offload dev <if-name> dir <in|out> ================================================================================ Performance results: TCP multi-stream, using iperf3 instance per-CPU. +----------------------+--------+--------+--------+--------+---------+---------+ | | 1 CPU | 2 CPUs | 4 CPUs | 8 CPUs | 16 CPUs | 32 CPUs | | +--------+--------+--------+--------+---------+---------+ | | BW (Gbps) | +----------------------+--------+--------+-------+---------+---------+---------+ | Baseline | 27.9 | 59 | 93.1 | 92.8 | 93.7 | 94.4 | +----------------------+--------+--------+-------+---------+---------+---------+ | Software IPsec | 6 | 11.9 | 23.3 | 45.9 | 83.8 | 91.8 | +----------------------+--------+--------+-------+---------+---------+---------+ | IPsec crypto offload | 15 | 29.7 | 58.5 | 89.6 | 90.4 | 90.8 | +----------------------+--------+--------+-------+---------+---------+---------+ | IPsec packet offload | 28 | 57 | 90.7 | 91 | 91.3 | 91.9 | +----------------------+--------+--------+-------+---------+---------+---------+ IPsec packet offload mode behaves as baseline and reaches linerate with same amount of CPUs. Setups details (similar for both sides): * NIC: ConnectX6-DX dual port, 100 Gbps each. Single port used in the tests. * CPU: Intel(R) Xeon(R) Platinum 8380 CPU @ 2.30GHz ================================================================================ Series together with mlx5 part: https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/log/?h=xfrm-next ================================================================================ Changelog: v10: * Added forgotten xdo_dev_state_del. Patch #4. * Moved changelog in cover letter to the end. * Added "if (xs->xso.type != XFRM_DEV_OFFLOAD_CRYPTO) {" line to newly added netronome IPsec support. Patch #2. v9: https://lore.kernel.org/all/cover.1669547603.git.leonro@nvidia.com * Added acquire support v8: https://lore.kernel.org/all/cover.1668753030.git.leonro@nvidia.com * Removed not-related blank line * Fixed typos in documentation v7: https://lore.kernel.org/all/cover.1667997522.git.leonro@nvidia.com As was discussed in IPsec workshop: * Renamed "full offload" to be "packet offload". * Added check that offloaded SA and policy have same device while sending packet * Added to SAD same optimization as was done for SPD to speed-up lookups. v6: https://lore.kernel.org/all/cover.1666692948.git.leonro@nvidia.com * Fixed misplaced "!" in sixth patch. v5: https://lore.kernel.org/all/cover.1666525321.git.leonro@nvidia.com * Rebased to latest ipsec-next. * Replaced HW priority patch with solution which mimics separated SPDs for SW and HW. See more description in this cover letter. * Dropped RFC tag, usecase, API and implementation are clear. v4: https://lore.kernel.org/all/cover.1662295929.git.leonro@nvidia.com * Changed title from "PATCH" to "PATCH RFC" per-request. * Added two new patches: one to update hard/soft limits and another initial take on documentation. * Added more info about lifetime/rekeying flow to cover letter, see relevant section. * perf traces for crypto mode will come later. v3: https://lore.kernel.org/all/cover.1661260787.git.leonro@nvidia.com * I didn't hear any suggestion what term to use instead of "packet offload", so left it as is. It is used in commit messages and documentation only and easy to rename. * Added performance data and background info to cover letter * Reused xfrm_output_resume() function to support multiple XFRM transformations * Add PMTU check in addition to driver .xdo_dev_offload_ok validation * Documentation is in progress, but not part of this series yet. v2: https://lore.kernel.org/all/cover.1660639789.git.leonro@nvidia.com * Rebased to latest 6.0-rc1 * Add an extra check in TX datapath patch to validate packets before forwarding to HW. * Added policy cleanup logic in case of netdev down event v1: https://lore.kernel.org/all/cover.1652851393.git.leonro@nvidia.com * Moved comment to be before if (...) in third patch. v0: https://lore.kernel.org/all/cover.1652176932.git.leonro@nvidia.com ----------------------------------------------------------------------- Thanks Leon Romanovsky (8): xfrm: add new packet offload flag xfrm: allow state packet offload mode xfrm: add an interface to offload policy xfrm: add TX datapath support for IPsec packet offload mode xfrm: add RX datapath protection for IPsec packet offload mode xfrm: speed-up lookup of HW policies xfrm: add support to HW update soft and hard limits xfrm: document IPsec packet offload mode Documentation/networking/xfrm_device.rst | 62 +++++- .../inline_crypto/ch_ipsec/chcr_ipsec.c | 4 + .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 5 + drivers/net/ethernet/intel/ixgbevf/ipsec.c | 5 + .../mellanox/mlx5/core/en_accel/ipsec.c | 4 + .../net/ethernet/netronome/nfp/crypto/ipsec.c | 5 + drivers/net/netdevsim/ipsec.c | 5 + include/linux/netdevice.h | 4 + include/net/xfrm.h | 124 +++++++++--- include/uapi/linux/xfrm.h | 6 + net/xfrm/xfrm_device.c | 109 +++++++++- net/xfrm/xfrm_output.c | 12 +- net/xfrm/xfrm_policy.c | 85 +++++++- net/xfrm/xfrm_state.c | 191 ++++++++++++++++-- net/xfrm/xfrm_user.c | 20 ++ 15 files changed, 577 insertions(+), 64 deletions(-)