From patchwork Wed Jan 4 09:43:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 13088373 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11F3AC4708E for ; Wed, 4 Jan 2023 09:43:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233862AbjADJnr (ORCPT ); Wed, 4 Jan 2023 04:43:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230376AbjADJnq (ORCPT ); Wed, 4 Jan 2023 04:43:46 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DD60AE7A; Wed, 4 Jan 2023 01:43:45 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5869EB811A2; Wed, 4 Jan 2023 09:43:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55DE1C433EF; Wed, 4 Jan 2023 09:43:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672825423; bh=GFCkxrwWNgg3EDS4bs73kYo8VaU7YWYv528Dyhkwodg=; h=From:To:Cc:Subject:Date:From; b=cBRdYwaF9rvneXWWpfBfXtC04WI/HLROvyAyCiBqFH9E6SHUI9oVJUnccX4MIYCJQ RE7Eea0nyS/BgIkiRGu3cTAmxEESMDcd1jaivPbSP78mAnFh2oowRnuAO8JDDGHEbi hgREYjjJ6ivL79VC0TsQLKnuOuE4g1FIVRik5fQ6C3tudtDDGv2IlAOizFxoZU1skD eus5Rb+3ImcV0O4WeRE5Dd4KaqexD6UoMxEkBf3REOOIP9yzpYpDfSSh9obuVQREcP VfG+nerm/fW1lCD6KzMtArHCVl96S24h12ThhEO3s1GxjsVR8FRc99s7y/Gm5yacZb Q745KtNOJCh3w== From: Leon Romanovsky To: Jason Gunthorpe Cc: Leon Romanovsky , Eric Dumazet , Jakub Kicinski , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Mark Zhang , netdev@vger.kernel.org, Paolo Abeni , Patrisious Haddad , Saeed Mahameed , Tariq Toukan , Yishai Hadas , Sagi Grimberg , Christoph Hellwig Subject: [PATCH rdma-next v1 0/3] Provide more error details when a QP moves to error state Date: Wed, 4 Jan 2023 11:43:33 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Leon Romanovsky Changelog: v1: * Reworked mlx4 to allow non-atomic IB QP event handler. v0: https://lore.kernel.org/linux-rdma/20220907113800.22182-1-phaddad@nvidia.com/ ------------------------------------------ The following series adds ability to get information about fatal QP events. This functionality is extremely useful for the following reasons: * Provides an information about the reason why QP moved to error state, in cases where CQE isn't generated. * Allows to provide vendor specfic error codes and information that could be very useful to users who know them. An example of a case without CQE is a remote write with RKEY violation. In this flow, on remote side no CQEs are generated and such error without indication is hard to debug. Thanks. Mark Zhang (1): RDMA/mlx: Calling qp event handler in workqueue context Patrisious Haddad (2): net/mlx5: Introduce CQE error syndrome RDMA/mlx5: Print error syndrome in case of fatal QP errors drivers/infiniband/hw/mlx4/main.c | 8 ++ drivers/infiniband/hw/mlx4/mlx4_ib.h | 3 + drivers/infiniband/hw/mlx4/qp.c | 121 +++++++++++------ drivers/infiniband/hw/mlx5/main.c | 7 + drivers/infiniband/hw/mlx5/qp.c | 164 ++++++++++++++++++------ drivers/infiniband/hw/mlx5/qp.h | 4 +- drivers/infiniband/hw/mlx5/qpc.c | 7 +- drivers/net/ethernet/mellanox/mlx4/qp.c | 14 +- include/linux/mlx4/qp.h | 1 + include/linux/mlx5/mlx5_ifc.h | 47 ++++++- include/rdma/ib_verbs.h | 2 +- 11 files changed, 292 insertions(+), 86 deletions(-)