mbox series

[xfrm-next,0/9] Extend packet offload to fully support libreswan

Message ID cover.1678714336.git.leon@kernel.org (mailing list archive)
Headers show
Series Extend packet offload to fully support libreswan | expand

Message

Leon Romanovsky March 14, 2023, 8:58 a.m. UTC
From: Leon Romanovsky <leonro@nvidia.com>

Hi Steffen,

The following patches are an outcome of Raed's work to add packet
offload support to libreswan [1].

The series includes:
 * Priority support to IPsec policies
 * Statistics per-SA (visible through "ip -s xfrm state ..." command)
 * Support to IKE policy holes
 * Fine tuning to acquire logic.

--------------------------
Future submission roadmap, which can be seen here [2]:
 * Support packet offload in IPsec tunnel mode
 * Rework lifetime counters support to avoid HW bugs/limitations
 * Some general cleanup.

So how do you want me to route the patches, as they have a dependency between them?
xfrm-next/net-next/mlx5-next?

Thanks

[1] https://github.com/libreswan/libreswan/pull/986q
[2] https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/log/?h=xfrm-next

Paul Blakey (3):
  net/mlx5: fs_chains: Refactor to detach chains from tc usage
  net/mlx5: fs_core: Allow ignore_flow_level on TX dest
  net/mlx5e: Use chains for IPsec policy priority offload

Raed Salem (6):
  xfrm: add new device offload acquire flag
  xfrm: copy_to_user_state fetch offloaded SA packets/bytes statistics
  net/mlx5e: Allow policies with reqid 0, to support IKE policy holes
  net/mlx5e: Support IPsec acquire default SA
  net/mlx5e: Use one rule to count all IPsec Tx offloaded traffic
  net/mlx5e: Update IPsec per SA packets/bytes count

 .../mellanox/mlx5/core/en_accel/ipsec.c       |  71 ++-
 .../mellanox/mlx5/core/en_accel/ipsec.h       |  13 +-
 .../mellanox/mlx5/core/en_accel/ipsec_fs.c    | 528 ++++++++++++++----
 .../mlx5/core/en_accel/ipsec_offload.c        |  32 +-
 .../net/ethernet/mellanox/mlx5/core/en_tc.c   |  20 +-
 .../mellanox/mlx5/core/eswitch_offloads.c     |   6 +-
 .../net/ethernet/mellanox/mlx5/core/fs_core.c |   5 +-
 .../mellanox/mlx5/core/lib/fs_chains.c        |  89 ++-
 .../mellanox/mlx5/core/lib/fs_chains.h        |   9 +-
 include/net/xfrm.h                            |   5 +
 net/xfrm/xfrm_state.c                         |   1 +
 net/xfrm/xfrm_user.c                          |   2 +
 12 files changed, 553 insertions(+), 228 deletions(-)

Comments

Leon Romanovsky March 19, 2023, 7:23 a.m. UTC | #1
On Tue, Mar 14, 2023 at 10:58:35AM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
> 
> Hi Steffen,

<...>

> So how do you want me to route the patches, as they have a dependency between them?
> xfrm-next/net-next/mlx5-next?

Can you please share your opinion and/or ack/nack xfrm patches, so we
will be able to progress?

Thanks

> 
> Thanks
> 
> [1] https://github.com/libreswan/libreswan/pull/986q
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/log/?h=xfrm-next
> 
> Paul Blakey (3):
>   net/mlx5: fs_chains: Refactor to detach chains from tc usage
>   net/mlx5: fs_core: Allow ignore_flow_level on TX dest
>   net/mlx5e: Use chains for IPsec policy priority offload
> 
> Raed Salem (6):
>   xfrm: add new device offload acquire flag
>   xfrm: copy_to_user_state fetch offloaded SA packets/bytes statistics
>   net/mlx5e: Allow policies with reqid 0, to support IKE policy holes
>   net/mlx5e: Support IPsec acquire default SA
>   net/mlx5e: Use one rule to count all IPsec Tx offloaded traffic
>   net/mlx5e: Update IPsec per SA packets/bytes count
> 
>  .../mellanox/mlx5/core/en_accel/ipsec.c       |  71 ++-
>  .../mellanox/mlx5/core/en_accel/ipsec.h       |  13 +-
>  .../mellanox/mlx5/core/en_accel/ipsec_fs.c    | 528 ++++++++++++++----
>  .../mlx5/core/en_accel/ipsec_offload.c        |  32 +-
>  .../net/ethernet/mellanox/mlx5/core/en_tc.c   |  20 +-
>  .../mellanox/mlx5/core/eswitch_offloads.c     |   6 +-
>  .../net/ethernet/mellanox/mlx5/core/fs_core.c |   5 +-
>  .../mellanox/mlx5/core/lib/fs_chains.c        |  89 ++-
>  .../mellanox/mlx5/core/lib/fs_chains.h        |   9 +-
>  include/net/xfrm.h                            |   5 +
>  net/xfrm/xfrm_state.c                         |   1 +
>  net/xfrm/xfrm_user.c                          |   2 +
>  12 files changed, 553 insertions(+), 228 deletions(-)
> 
> -- 
> 2.39.2
>
Steffen Klassert March 20, 2023, 8:56 a.m. UTC | #2
On Tue, Mar 14, 2023 at 10:58:35AM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
> 
> Hi Steffen,
> 
> The following patches are an outcome of Raed's work to add packet
> offload support to libreswan [1].
> 
> The series includes:
>  * Priority support to IPsec policies
>  * Statistics per-SA (visible through "ip -s xfrm state ..." command)
>  * Support to IKE policy holes
>  * Fine tuning to acquire logic.
> 
> --------------------------
> Future submission roadmap, which can be seen here [2]:
>  * Support packet offload in IPsec tunnel mode
>  * Rework lifetime counters support to avoid HW bugs/limitations
>  * Some general cleanup.
> 
> So how do you want me to route the patches, as they have a dependency between them?
> xfrm-next/net-next/mlx5-next?

As the changes to the xfrm core are just minor compared to the rest
of the patchset, I'd not absolutely require to route it through
ipsec-next. Do it as you prefer, but let me know how you plan
to do it.
Leon Romanovsky March 20, 2023, 9:09 a.m. UTC | #3
On Mon, Mar 20, 2023 at 09:56:42AM +0100, Steffen Klassert wrote:
> On Tue, Mar 14, 2023 at 10:58:35AM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> > 
> > Hi Steffen,
> > 
> > The following patches are an outcome of Raed's work to add packet
> > offload support to libreswan [1].
> > 
> > The series includes:
> >  * Priority support to IPsec policies
> >  * Statistics per-SA (visible through "ip -s xfrm state ..." command)
> >  * Support to IKE policy holes
> >  * Fine tuning to acquire logic.
> > 
> > --------------------------
> > Future submission roadmap, which can be seen here [2]:
> >  * Support packet offload in IPsec tunnel mode
> >  * Rework lifetime counters support to avoid HW bugs/limitations
> >  * Some general cleanup.
> > 
> > So how do you want me to route the patches, as they have a dependency between them?
> > xfrm-next/net-next/mlx5-next?
> 
> As the changes to the xfrm core are just minor compared to the rest
> of the patchset, I'd not absolutely require to route it through
> ipsec-next. Do it as you prefer, but let me know how you plan
> to do it.

I prefer to prepare and send PR directly to netdev, but I need your
Acked-by on xfrm patches first, before doing it.

Thanks