mbox series

[v2,net-next,0/4] selftests: fcnal: Test SO_DONTROUTE socket option.

Message ID cover.1683814269.git.gnault@redhat.com (mailing list archive)
Headers show
Series selftests: fcnal: Test SO_DONTROUTE socket option. | expand

Message

Guillaume Nault May 11, 2023, 2:39 p.m. UTC
The objective is to cover kernel paths that use the RTO_ONLINK flag
in .flowi4_tos. This way we'll be able to safely remove this flag in
the future by properly setting .flowi4_scope instead. With these
selftests in place, we can make sure this won't introduce regressions.

For more context, the final objective is to convert .flowi4_tos to
dscp_t, to ensure that ECN bits don't influence route and fib-rule
lookups (see commit a410a0cf9885 ("ipv6: Define dscp_t and stop taking
ECN bits into account in fib6-rules")).

These selftests only cover IPv4, as SO_DONTROUTE has no effect on IPv6
sockets.

v2:
  - Use two different nettest options for setting SO_DONTROUTE either
    on the server or on the client socket.

  - Use the above feature to run a single 'nettest -B' instance per
    test (instead of having two nettest processes for server and
    client).

Guillaume Nault (4):
  selftests: Add SO_DONTROUTE option to nettest.
  selftests: fcnal: Test SO_DONTROUTE on TCP sockets.
  selftests: fcnal: Test SO_DONTROUTE on UDP sockets.
  selftests: fcnal: Test SO_DONTROUTE on raw and ping sockets.

 tools/testing/selftests/net/fcnal-test.sh | 87 +++++++++++++++++++++++
 tools/testing/selftests/net/nettest.c     | 46 +++++++++++-
 2 files changed, 132 insertions(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org May 12, 2023, 8:50 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 11 May 2023 16:39:19 +0200 you wrote:
> The objective is to cover kernel paths that use the RTO_ONLINK flag
> in .flowi4_tos. This way we'll be able to safely remove this flag in
> the future by properly setting .flowi4_scope instead. With these
> selftests in place, we can make sure this won't introduce regressions.
> 
> For more context, the final objective is to convert .flowi4_tos to
> dscp_t, to ensure that ECN bits don't influence route and fib-rule
> lookups (see commit a410a0cf9885 ("ipv6: Define dscp_t and stop taking
> ECN bits into account in fib6-rules")).
> 
> [...]

Here is the summary with links:
  - [v2,net-next,1/4] selftests: Add SO_DONTROUTE option to nettest.
    https://git.kernel.org/netdev/net-next/c/aeefbb574c38
  - [v2,net-next,2/4] selftests: fcnal: Test SO_DONTROUTE on TCP sockets.
    https://git.kernel.org/netdev/net-next/c/dd017c72dde6
  - [v2,net-next,3/4] selftests: fcnal: Test SO_DONTROUTE on UDP sockets.
    https://git.kernel.org/netdev/net-next/c/a431327c4faa
  - [v2,net-next,4/4] selftests: fcnal: Test SO_DONTROUTE on raw and ping sockets.
    https://git.kernel.org/netdev/net-next/c/ceec9f272432

You are awesome, thank you!