| Message ID | cover.1692191034.git.antony.antony@secunet.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | xfrm: Support GRO decapsulation for ESP in UDP encapsulation | expand |
Hi Antony, On Wed, Aug 16, 2023 at 4:12 PM Antony Antony <antony.antony@secunet.com> wrote: > > Hi, > Here I re-worked this patch set and here is v5 based of feed back from Eyal. I think the cover letter should include a little more information :) Specifically I think it would be useful to add performance numbers, usage, and the relevant caveats - especially the fact that UDP encapsulated flows will no longer be connection tracked or protected by netfilter. For the series itself: Reviewed-by: Eyal Birger <eyal.birger@gmail.com> > > > v1->v2 fixed error path added skb_push > use is_fou instead of holding sk in skb. > user configurable option to enable GRO; using UDP_GRO > > v2->v3 only support GRO for UDP_ENCAP_ESPINUDP and not > UDP_ENCAP_ESPINUDP_NON_IKE. The _NON_IKE is an IETF early draft > version and not widly used. > > v3->v4 removed refactoring since refactored function is only used once > removed refcount on sk, sk is not used any more. > fixed encap_type as Eyal recommended. > removed un-necessary else since there is a goto before that. > > v4->v5 removed extra code/checks that accidently got added. > > > Steffen Klassert (3): > xfrm: Use the XFRM_GRO to indicate a GRO call on input > xfrm: Support GRO for IPv4 ESP in UDP encapsulation > xfrm: Support GRO for IPv6 ESP in UDP encapsulation > > include/net/gro.h | 2 +- > include/net/ipv6_stubs.h | 3 ++ > include/net/xfrm.h | 4 ++ > net/ipv4/esp4_offload.c | 6 ++- > net/ipv4/udp.c | 16 +++++++ > net/ipv4/xfrm4_input.c | 94 ++++++++++++++++++++++++++++++++-------- > net/ipv6/af_inet6.c | 1 + > net/ipv6/esp6_offload.c | 10 ++++- > net/ipv6/xfrm6_input.c | 94 ++++++++++++++++++++++++++++++++-------- > net/xfrm/xfrm_input.c | 6 +-- > 10 files changed, 192 insertions(+), 44 deletions(-) > > -- > 2.30.2 >
Hi, Here I re-worked this patch set and here is v5 based of feed back from Eyal. v1->v2 fixed error path added skb_push use is_fou instead of holding sk in skb. user configurable option to enable GRO; using UDP_GRO v2->v3 only support GRO for UDP_ENCAP_ESPINUDP and not UDP_ENCAP_ESPINUDP_NON_IKE. The _NON_IKE is an IETF early draft version and not widly used. v3->v4 removed refactoring since refactored function is only used once removed refcount on sk, sk is not used any more. fixed encap_type as Eyal recommended. removed un-necessary else since there is a goto before that. v4->v5 removed extra code/checks that accidently got added. Steffen Klassert (3): xfrm: Use the XFRM_GRO to indicate a GRO call on input xfrm: Support GRO for IPv4 ESP in UDP encapsulation xfrm: Support GRO for IPv6 ESP in UDP encapsulation include/net/gro.h | 2 +- include/net/ipv6_stubs.h | 3 ++ include/net/xfrm.h | 4 ++ net/ipv4/esp4_offload.c | 6 ++- net/ipv4/udp.c | 16 +++++++ net/ipv4/xfrm4_input.c | 94 ++++++++++++++++++++++++++++++++-------- net/ipv6/af_inet6.c | 1 + net/ipv6/esp6_offload.c | 10 ++++- net/ipv6/xfrm6_input.c | 94 ++++++++++++++++++++++++++++++++-------- net/xfrm/xfrm_input.c | 6 +-- 10 files changed, 192 insertions(+), 44 deletions(-) -- 2.30.2