[bpf-next,0/3] samples/bpf: Allow building as PIE

Message

Viktor Malik Oct. 25, 2023, 6:19 a.m. UTC

Hi,

when trying to build samples/bpf as PIE in Fedora, we came across
several issues, mainly related to the way compiler/linker flags are
handled in samples/bpf/Makefile. The first 2 commits in this patchset
address these issues (see commit messages for details).

At the same time, this proposes to allow passing an already built
bpftool to samples/bpf/Makefile. The reason is to remove a redundant
build step but also because I was not able to find a correct combination
of build flags to build libbpf.a for samples/bpf/bpftool/ with -fPIE.

Viktor Malik (3):
  samples/bpf: Allow building with custom CFLAGS/LDFLAGS
  samples/bpf: Fix passing LDFLAGS to libbpf
  samples/bpf: Allow building with custom bpftool

 samples/bpf/Makefile | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Comments

[e-mail] Oct. 26, 2023, 1:40 p.m. UTC | #1

Hello:

This series was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <[e-mail]>:

On Wed, 25 Oct 2023 08:19:11 +0200 you wrote:
> Hi,
> 
> when trying to build samples/bpf as PIE in Fedora, we came across
> several issues, mainly related to the way compiler/linker flags are
> handled in samples/bpf/Makefile. The first 2 commits in this patchset
> address these issues (see commit messages for details).
> 
> [...]

Here is the summary with links:
  - [bpf-next,1/3] samples/bpf: Allow building with custom CFLAGS/LDFLAGS
    https://git.kernel.org/bpf/bpf-next/c/870f09f1ba30
  - [bpf-next,2/3] samples/bpf: Fix passing LDFLAGS to libbpf
    https://git.kernel.org/bpf/bpf-next/c/f56bcfadf7d6
  - [bpf-next,3/3] samples/bpf: Allow building with custom bpftool
    https://git.kernel.org/bpf/bpf-next/c/37db10bc247d

You are awesome, thank you!