mbox series

[net-next,0/3] mlxsw: CFF flood mode: NVE underlay configuration

Message ID cover.1702557104.git.petrm@nvidia.com (mailing list archive)
Headers show
Series mlxsw: CFF flood mode: NVE underlay configuration | expand

Message

Petr Machata Dec. 14, 2023, 1:19 p.m. UTC
Recently, support for CFF flood mode (for Compressed FID Flooding) was
added to the mlxsw driver. The most recent patchset has a detailed coverage
of what CFF is and what has changed and how:

    https://lore.kernel.org/netdev/cover.1701183891.git.petrm@nvidia.com/

In CFF flood mode, each FID allocates a handful (in our implementation two
or three) consecutive PGT entries. One entry holds the flood vector for
unknown-UC traffic, one for MC, one for BC.

To determine how to look up flood vectors, the CFF flood mode uses a
concept of flood profiles, which are IDs that reference mappings from
traffic types to offsets. In the case of CFF flood mode, the offset in
question is applied to the PGT address configured at a FID. The same
mechanism is used by NVE underlay for flooding. Again the profile ID and
the traffic type determine the offset to apply, this time to KVD address
used to look up flooding entries. Since mlxsw configures NVE underlay flood
the same regardless of traffic type, only one offset was ever needed: the
zero, which is the default, and thus no explicit configuration was needed.

Now that CFF uses profiles as well, it would be better to configure the
profile used by NVE explicitly, to make the configuration visible in the
source code.

In this patchset, add the register support (in patch #1), add a new traffic
type to refer to "any traffic at all" (in patch #2) and finally configure
the NVE profile explicitly for FIDs (in patch #3).

So far, the implicitly configured flood profile was the ID 0. With this
patchset, it changes to 3, leaving the 0 free to allow us to spot missed
configuration.

Petr Machata (3):
  mlxsw: reg: Add nve_flood_prf_id field to SFMR
  mlxsw: spectrum_fid: Add an "any" packet type
  mlxsw: spectrum_fid: Set NVE flood profile as part of FID
    configuration

 drivers/net/ethernet/mellanox/mlxsw/reg.h     |  9 ++++++
 .../net/ethernet/mellanox/mlxsw/spectrum.h    |  2 ++
 .../ethernet/mellanox/mlxsw/spectrum_fid.c    | 29 +++++++++++++++++++
 3 files changed, 40 insertions(+)

Comments

patchwork-bot+netdevbpf@kernel.org Dec. 15, 2023, 11 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 14 Dec 2023 14:19:04 +0100 you wrote:
> Recently, support for CFF flood mode (for Compressed FID Flooding) was
> added to the mlxsw driver. The most recent patchset has a detailed coverage
> of what CFF is and what has changed and how:
> 
>     https://lore.kernel.org/netdev/cover.1701183891.git.petrm@nvidia.com/
> 
> In CFF flood mode, each FID allocates a handful (in our implementation two
> or three) consecutive PGT entries. One entry holds the flood vector for
> unknown-UC traffic, one for MC, one for BC.
> 
> [...]

Here is the summary with links:
  - [net-next,1/3] mlxsw: reg: Add nve_flood_prf_id field to SFMR
    https://git.kernel.org/netdev/net-next/c/d9d441e8e89d
  - [net-next,2/3] mlxsw: spectrum_fid: Add an "any" packet type
    https://git.kernel.org/netdev/net-next/c/b2f5eb5a6509
  - [net-next,3/3] mlxsw: spectrum_fid: Set NVE flood profile as part of FID configuration
    https://git.kernel.org/netdev/net-next/c/6dab4083260b

You are awesome, thank you!