| Message ID | cover.1707848297.git.thinhtr@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | bnx2x: Fix error recovering in switch configuration | expand |
On 2/13/2024 10:32 AM, Thinh Tran wrote: > Please refer to the initial cover letter > https://lore.kernel.org/all/20230818161443.708785-1-thinhtr@linux.vnet.ibm.com > > In series Version 6, the patch > [v6,1/4] bnx2x: new flag for tracking HW resource > was successfully made it to the mainline kernel > https://github.com/torvalds/linux/commit/bf23ffc8a9a777dfdeb04232e0946b803adbb6a9 > but the rest of the patches did not. > > The following patch has been excluded from this series: > net/bnx2x: prevent excessive debug information during a TX timeout > based on concerns raised by some developers that it might omit valuable > debugging details as in some other scenarios may cause the TX timeout. > > > v9: adding "Fixes:" tag to commit messages for patch > net/bnx2x: Prevent access to a freed page in page_pool > > v8: adding stack trace to commit messages for patch > net/bnx2x: Prevent access to a freed page in page_pool > > v7: resubmitting patches. > The subject didn't clearly identify net-next or net... but the contents of the series seem to be one bug fix which would make sense to go to net (unless the bug itself isn't in net yet?) and one refactor that doesn't seem reasonable to go to net..
Thank you for the feed back On 2/14/2024 2:48 PM, Jacob Keller wrote: > > The subject didn't clearly identify net-next or net... but the contents > of the series seem to be one bug fix which would make sense to go to net > (unless the bug itself isn't in net yet?) and one refactor that doesn't > seem reasonable to go to net.. I agree that the refactor patch does not need to be included in the 'net' tree. Should the patches be resubmitted separately, with one targeted for 'net' and the other for 'net-next'? Your advice on the best approach would be greatly appreciated. Thanks Thinh Tran
On 2/15/2024 8:08 AM, Thinh Tran wrote: > > Thank you for the feed back > On 2/14/2024 2:48 PM, Jacob Keller wrote: >> >> The subject didn't clearly identify net-next or net... but the contents >> of the series seem to be one bug fix which would make sense to go to net >> (unless the bug itself isn't in net yet?) and one refactor that doesn't >> seem reasonable to go to net.. > > I agree that the refactor patch does not need to be included in the > 'net' tree. > Should the patches be resubmitted separately, with one targeted for > 'net' and the other for 'net-next'? Your advice on the best approach > would be greatly appreciated. > > Thanks > Thinh Tran Yep. Targeting the fix to net means it will hit the next release and can get ported to the stable trees. Thanks, Jake
Please refer to the initial cover letter https://lore.kernel.org/all/20230818161443.708785-1-thinhtr@linux.vnet.ibm.com In series Version 6, the patch [v6,1/4] bnx2x: new flag for tracking HW resource was successfully made it to the mainline kernel https://github.com/torvalds/linux/commit/bf23ffc8a9a777dfdeb04232e0946b803adbb6a9 but the rest of the patches did not. The following patch has been excluded from this series: net/bnx2x: prevent excessive debug information during a TX timeout based on concerns raised by some developers that it might omit valuable debugging details as in some other scenarios may cause the TX timeout. v9: adding "Fixes:" tag to commit messages for patch net/bnx2x: Prevent access to a freed page in page_pool v8: adding stack trace to commit messages for patch net/bnx2x: Prevent access to a freed page in page_pool v7: resubmitting patches. Hereby resubmitting the two patches below: Thinh Tran (2): net/bnx2x: Prevent access to a freed page in page_pool net/bnx2x: refactor common code to bnx2x_stop_nic() .../net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 28 +++++++++++-------- .../net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 7 +++-- .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 25 +++-------------- .../net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c | 12 ++------ 4 files changed, 27 insertions(+), 45 deletions(-)