mbox series

[net-next,v2,0/2] Add IP/port information to UDP drop tracepoint

Message ID cover.1710866188.git.balazs.scheidler@axoflow.com (mailing list archive)
Headers show
Series Add IP/port information to UDP drop tracepoint | expand

Message

Balazs Scheidler March 19, 2024, 4:39 p.m. UTC
Hi,

In our use-case we would like to recover the properties of dropped UDP
packets. Unfortunately the current udp_fail_queue_rcv_skb tracepoint
only exposes the port number of the receiving socket.

This patch-set will add the source/dest ip/port to the tracepoint, while 
keeping the socket's local port as well for compatibility.

v2 updates:
  * Addressed review notes by Kuniyuki Iwashima <kuniyu@amazon.com>

Balazs Scheidler (2):
  net: port TP_STORE_ADDR_PORTS_SKB macro to be tcp/udp independent
  net: udp: add IP/port data to the tracepoint
    udp/udp_fail_queue_rcv_skb

 include/trace/events/net_probe_common.h | 41 ++++++++++++++++++++++
 include/trace/events/tcp.h              | 45 ++-----------------------
 include/trace/events/udp.h              | 33 +++++++++++++++---
 net/ipv4/udp.c                          |  2 +-
 net/ipv6/udp.c                          |  3 +-
 5 files changed, 75 insertions(+), 49 deletions(-)

Comments

Jakub Kicinski March 20, 2024, 2:42 a.m. UTC | #1
On Tue, 19 Mar 2024 17:39:06 +0100 Balazs Scheidler wrote:
> In our use-case we would like to recover the properties of dropped UDP
> packets. Unfortunately the current udp_fail_queue_rcv_skb tracepoint
> only exposes the port number of the receiving socket.
> 
> This patch-set will add the source/dest ip/port to the tracepoint, while 
> keeping the socket's local port as well for compatibility.


This doesn't apply to current net-next, please rebase.
Please repost in a week, until -rc1 is cut we do not accept any
net-next patches, see:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle