| Message ID | cover.1711475011.git.balazs.scheidler@axoflow.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add IP/port information to UDP drop tracepoint | expand |
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 26 Mar 2024 19:05:45 +0100 you wrote: > Hi, > > In our use-case we would like to recover the properties of dropped UDP > packets. Unfortunately the current udp_fail_queue_rcv_skb tracepoint > only exposes the port number of the receiving socket. > > This patch-set will add the source/dest ip/port to the tracepoint, while > keeping the socket's local port as well for compatibility. > > [...] Here is the summary with links: - [net-next,v4,1/2] net: port TP_STORE_ADDR_PORTS_SKB macro to be tcp/udp independent https://git.kernel.org/netdev/net-next/c/a0ad11fc2632 - [net-next,v4,2/2] net: udp: add IP/port data to the tracepoint udp/udp_fail_queue_rcv_skb https://git.kernel.org/netdev/net-next/c/e9669a00bba7 You are awesome, thank you!
Hi, In our use-case we would like to recover the properties of dropped UDP packets. Unfortunately the current udp_fail_queue_rcv_skb tracepoint only exposes the port number of the receiving socket. This patch-set will add the source/dest ip/port to the tracepoint, while keeping the socket's local port as well for compatibility. Thanks for the review comments by Jason and Kuniyuki, they helped me a lot and I tried to address all of their comments in this new iteration. v4 updates: * fixed checkpatch.pl warnings * rebased against latest net-next v3 updates: * Dropped "lport" as suggested by Jason Xing <kerneljasonxing@gmail.com> * Clear saddr/daddr fields using memset() before populating the fields as suggested by Jason Xing. v2 updates: * Addressed review notes by Kuniyuki Iwashima <kuniyu@amazon.com> Balazs Scheidler (2): net: port TP_STORE_ADDR_PORTS_SKB macro to be tcp/udp independent net: udp: add IP/port data to the tracepoint udp/udp_fail_queue_rcv_skb include/trace/events/net_probe_common.h | 40 ++++++++++++++++++++++ include/trace/events/tcp.h | 45 ++----------------------- include/trace/events/udp.h | 29 +++++++++++++--- net/ipv4/udp.c | 2 +- net/ipv6/udp.c | 3 +- 5 files changed, 69 insertions(+), 50 deletions(-)