mbox series

[net,v2,0/3] mlxsw: Fixes

Message ID cover.1713446092.git.petrm@nvidia.com (mailing list archive)
Headers show
Series mlxsw: Fixes | expand

Message

Petr Machata April 18, 2024, 1:46 p.m. UTC 
This patchset fixes the following issues:

- During driver de-initialization the driver unregisters the EMAD
  response trap by setting its action to DISCARD. However the manual
  only permits TRAP and FORWARD, and future firmware versions will
  enforce this.

  In patch #1, suppress the error message by aligning the driver to the
  manual and use a FORWARD (NOP) action when unregistering the trap.

- The driver queries the Management Capabilities Mask (MCAM) register
  during initialization to understand if certain features are supported.

  However, not all firmware versions support this register, leading to
  the driver failing to load.

  Patches #2 and #3 fix this issue by treating an error in the register
  query as an indication that the feature is not supported.

v2:
- Patch #2:
    - Make mlxsw_env_max_module_eeprom_len_query() void

Ido Schimmel (3):
  mlxsw: core: Unregister EMAD trap using FORWARD action
  mlxsw: core_env: Fix driver initialization with old firmware
  mlxsw: pci: Fix driver initialization with old firmware

 drivers/net/ethernet/mellanox/mlxsw/core.c    |  2 +-
 .../net/ethernet/mellanox/mlxsw/core_env.c    | 20 ++++++-------------
 drivers/net/ethernet/mellanox/mlxsw/pci.c     | 10 ++++------
 3 files changed, 11 insertions(+), 21 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org April 20, 2024, 3:50 a.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 18 Apr 2024 15:46:05 +0200 you wrote:
> This patchset fixes the following issues:
> 
> - During driver de-initialization the driver unregisters the EMAD
>   response trap by setting its action to DISCARD. However the manual
>   only permits TRAP and FORWARD, and future firmware versions will
>   enforce this.
> 
> [...]

Here is the summary with links:
  - [net,v2,1/3] mlxsw: core: Unregister EMAD trap using FORWARD action
    https://git.kernel.org/netdev/net/c/976c44af4814
  - [net,v2,2/3] mlxsw: core_env: Fix driver initialization with old firmware
    https://git.kernel.org/netdev/net/c/7e2050a83663
  - [net,v2,3/3] mlxsw: pci: Fix driver initialization with old firmware
    https://git.kernel.org/netdev/net/c/773501d01e6b

You are awesome, thank you!