mbox series

[net,0/2] gre: Revert IPv6 link-local address fix.

Message ID cover.1742418408.git.gnault@redhat.com (mailing list archive)
Headers show
Series gre: Revert IPv6 link-local address fix. | expand

Message

Guillaume Nault March 19, 2025, 9:26 p.m. UTC
Following Paolo's suggestion, let's revert the IPv6 link-local address
generation fix for GRE devices. The patch introduced regressions in the
upstream CI, which are still under investigation.

Start by reverting the kselftest that depend on that fix (patch 1), then
revert the kernel code itself (patch 2).

Guillaume Nault (2):
  Revert "selftests: Add IPv6 link-local address generation tests for
    GRE devices."
  Revert "gre: Fix IPv6 link-local address generation."

 net/ipv6/addrconf.c                           |  15 +-
 tools/testing/selftests/net/Makefile          |   1 -
 .../testing/selftests/net/gre_ipv6_lladdr.sh  | 177 ------------------
 3 files changed, 6 insertions(+), 187 deletions(-)
 delete mode 100755 tools/testing/selftests/net/gre_ipv6_lladdr.sh

Comments

Stanislav Fomichev March 19, 2025, 9:35 p.m. UTC | #1
On 03/19, Guillaume Nault wrote:
> Following Paolo's suggestion, let's revert the IPv6 link-local address
> generation fix for GRE devices. The patch introduced regressions in the
> upstream CI, which are still under investigation.
> 
> Start by reverting the kselftest that depend on that fix (patch 1), then
> revert the kernel code itself (patch 2).

Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Paolo Abeni March 19, 2025, 10:04 p.m. UTC | #2
On 3/19/25 10:26 PM, Guillaume Nault wrote:
> Following Paolo's suggestion, let's revert the IPv6 link-local address
> generation fix for GRE devices. The patch introduced regressions in the
> upstream CI, which are still under investigation.
> 
> Start by reverting the kselftest that depend on that fix (patch 1), then
> revert the kernel code itself (patch 2).
> 
> Guillaume Nault (2):
>   Revert "selftests: Add IPv6 link-local address generation tests for
>     GRE devices."
>   Revert "gre: Fix IPv6 link-local address generation."
> 
>  net/ipv6/addrconf.c                           |  15 +-
>  tools/testing/selftests/net/Makefile          |   1 -
>  .../testing/selftests/net/gre_ipv6_lladdr.sh  | 177 ------------------
>  3 files changed, 6 insertions(+), 187 deletions(-)
>  delete mode 100755 tools/testing/selftests/net/gre_ipv6_lladdr.sh

I'm going to apply this series well below the 24 grace period, to fit
tomorrow's PR.

Any feedback more than welcome, but it need to be fast ;)

Thanks,

Paolo
patchwork-bot+netdevbpf@kernel.org March 20, 2025, 3 p.m. UTC | #3
Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Wed, 19 Mar 2025 22:26:39 +0100 you wrote:
> Following Paolo's suggestion, let's revert the IPv6 link-local address
> generation fix for GRE devices. The patch introduced regressions in the
> upstream CI, which are still under investigation.
> 
> Start by reverting the kselftest that depend on that fix (patch 1), then
> revert the kernel code itself (patch 2).
> 
> [...]

Here is the summary with links:
  - [net,1/2] Revert "selftests: Add IPv6 link-local address generation tests for GRE devices."
    https://git.kernel.org/netdev/net/c/355d940f4d5a
  - [net,2/2] Revert "gre: Fix IPv6 link-local address generation."
    https://git.kernel.org/netdev/net/c/fc486c2d060f

You are awesome, thank you!