| Message ID | 0d2504d1-e150-40bf-8e30-bf6414d42b60@ans.pl (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e1a65d47551f3a9276767f482d1cf9a55c2b5460 |
| Delegated to: | Michal Kubecek |
| Headers | show |
| Series | [v2,ethtool] qsfp: Better handling of Page 03h netlink read failure | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Tue, Jul 30, 2024 at 05:49:33PM -0700, Krzysztof Olędzki wrote: > When dumping the EEPROM contents of a QSFP transceiver module, ethtool > will only ask the kernel to retrieve Upper Page 03h if the module > advertised it as supported. > > However, some kernel drivers like mlx4 are currently unable to provide > the page, resulting in the kernel returning an error. Since Upper Page > 03h is optional, do not treat the error as fatal. Instead, print an > error message and allow ethtool to continue and parse / print the > contents of the other pages. > > Also, clarify potentially cryptic "netlink error: Invalid argument" message. > > Before: > # ethtool -m eth3 > netlink error: Invalid argument > > After: > # ethtool -m eth3 > netlink error: Invalid argument > Failed to read Upper Page 03h, driver error? > Identifier : 0x0d (QSFP+) > Extended identifier : 0x00 > (...) > > Fixes: 25b64c66f58d ("ethtool: Add netlink handler for getmodule (-m)") > Nit: No blank line between Fixes and SoB, but maybe Michal can fix it up when applying > Signed-off-by: Krzysztof Piotr Oledzki <ole@ans.pl> Reviewed-by: Ido Schimmel <idosch@nvidia.com> Thanks!
On 31.07.2024 at 01:20, Ido Schimmel wrote: > On Tue, Jul 30, 2024 at 05:49:33PM -0700, Krzysztof Olędzki wrote: >> When dumping the EEPROM contents of a QSFP transceiver module, ethtool >> will only ask the kernel to retrieve Upper Page 03h if the module >> advertised it as supported. >> >> However, some kernel drivers like mlx4 are currently unable to provide >> the page, resulting in the kernel returning an error. Since Upper Page >> 03h is optional, do not treat the error as fatal. Instead, print an >> error message and allow ethtool to continue and parse / print the >> contents of the other pages. >> >> Also, clarify potentially cryptic "netlink error: Invalid argument" message. >> >> Before: >> # ethtool -m eth3 >> netlink error: Invalid argument >> >> After: >> # ethtool -m eth3 >> netlink error: Invalid argument >> Failed to read Upper Page 03h, driver error? >> Identifier : 0x0d (QSFP+) >> Extended identifier : 0x00 >> (...) >> >> Fixes: 25b64c66f58d ("ethtool: Add netlink handler for getmodule (-m)") >> > > Nit: No blank line between Fixes and SoB, but maybe Michal can fix it up > when applying Ah... thanks. :/ Michal, please let me know if I should send a v3 or if you can correct this issue. Krzysztof
On Wed, 31 Jul 2024 06:58:08 -0700 Krzysztof Olędzki wrote: > > Nit: No blank line between Fixes and SoB, but maybe Michal can fix it up > > when applying > > Ah... thanks. :/ > > Michal, please let me know if I should send a v3 or if you can correct this issue. We haven't heard from Michal in a couple of weeks, I recommend you correct and repost this one :(
Hello: This patch was applied to ethtool/ethtool.git (master) by Michal Kubecek <mkubecek@suse.cz>: On Tue, 30 Jul 2024 17:49:33 -0700 you wrote: > When dumping the EEPROM contents of a QSFP transceiver module, ethtool > will only ask the kernel to retrieve Upper Page 03h if the module > advertised it as supported. > > However, some kernel drivers like mlx4 are currently unable to provide > the page, resulting in the kernel returning an error. Since Upper Page > 03h is optional, do not treat the error as fatal. Instead, print an > error message and allow ethtool to continue and parse / print the > contents of the other pages. > > [...] Here is the summary with links: - [v2,ethtool] qsfp: Better handling of Page 03h netlink read failure https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=e1a65d47551f You are awesome, thank you!
diff --git a/qsfp.c b/qsfp.c index a2921fb..a3a919d 100644 --- a/qsfp.c +++ b/qsfp.c @@ -1038,8 +1038,15 @@ sff8636_memory_map_init_pages(struct cmd_context *ctx, sff8636_request_init(&request, 0x3, SFF8636_PAGE_SIZE); ret = nl_get_eeprom_page(ctx, &request); - if (ret < 0) - return ret; + if (ret < 0) { + /* Page 03h is not available due to a bug in the driver. + * This is a non-fatal error and sff8636_dom_parse() + * handles this correctly. + */ + fprintf(stderr, "Failed to read Upper Page 03h, driver error?\n"); + return 0; + } + map->page_03h = request.data - SFF8636_PAGE_SIZE; return 0;
When dumping the EEPROM contents of a QSFP transceiver module, ethtool will only ask the kernel to retrieve Upper Page 03h if the module advertised it as supported. However, some kernel drivers like mlx4 are currently unable to provide the page, resulting in the kernel returning an error. Since Upper Page 03h is optional, do not treat the error as fatal. Instead, print an error message and allow ethtool to continue and parse / print the contents of the other pages. Also, clarify potentially cryptic "netlink error: Invalid argument" message. Before: # ethtool -m eth3 netlink error: Invalid argument After: # ethtool -m eth3 netlink error: Invalid argument Failed to read Upper Page 03h, driver error? Identifier : 0x0d (QSFP+) Extended identifier : 0x00 (...) Fixes: 25b64c66f58d ("ethtool: Add netlink handler for getmodule (-m)") Signed-off-by: Krzysztof Piotr Oledzki <ole@ans.pl> --- qsfp.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)