| Message ID | 0f822c0b72f8b71555c11745cb8fb33399d02de9.1683578488.git.lorenzo@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9d142ed484a3d517e779fc3c16028a720762643f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: veth: rely on napi_build_skb in veth_convert_skb_to_xdp_buff | expand |
On 2023/5/9 4:45, Lorenzo Bianconi wrote: > Since veth_convert_skb_to_xdp_buff routine runs in veth_poll() NAPI, > rely on napi_build_skb() instead of build_skb() to reduce skb allocation > cost. LGTM. Reviewed-by: Yunsheng Lin <linyunsheng@huawei.com> > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > --- > drivers/net/veth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/veth.c b/drivers/net/veth.c > index dce9f9d63e04..3ae496011640 100644 > --- a/drivers/net/veth.c > +++ b/drivers/net/veth.c > @@ -747,7 +747,7 @@ static int veth_convert_skb_to_xdp_buff(struct veth_rq *rq, > if (!page) > goto drop; > > - nskb = build_skb(page_address(page), PAGE_SIZE); > + nskb = napi_build_skb(page_address(page), PAGE_SIZE); > if (!nskb) { > page_pool_put_full_page(rq->page_pool, page, true); > goto drop; >
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 8 May 2023 22:45:23 +0200 you wrote: > Since veth_convert_skb_to_xdp_buff routine runs in veth_poll() NAPI, > rely on napi_build_skb() instead of build_skb() to reduce skb allocation > cost. > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > --- > drivers/net/veth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next] net: veth: rely on napi_build_skb in veth_convert_skb_to_xdp_buff https://git.kernel.org/netdev/net-next/c/9d142ed484a3 You are awesome, thank you!
diff --git a/drivers/net/veth.c b/drivers/net/veth.c index dce9f9d63e04..3ae496011640 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -747,7 +747,7 @@ static int veth_convert_skb_to_xdp_buff(struct veth_rq *rq, if (!page) goto drop; - nskb = build_skb(page_address(page), PAGE_SIZE); + nskb = napi_build_skb(page_address(page), PAGE_SIZE); if (!nskb) { page_pool_put_full_page(rq->page_pool, page, true); goto drop;
Since veth_convert_skb_to_xdp_buff routine runs in veth_poll() NAPI, rely on napi_build_skb() instead of build_skb() to reduce skb allocation cost. Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> --- drivers/net/veth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)