| Message ID | 1604721272-23314-1-git-send-email-yanjunz@nvidia.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [1/1] net/mlx5e: remove unnecessary memset | expand |
On Sat, 2020-11-07 at 11:54 +0800, Zhu Yanjun wrote: > Since kvzalloc will initialize the allocated memory, it is not > necessary to initialize it once again. > > Fixes: 11b717d61526 ("net/mlx5: E-Switch, Get reg_c0 value on CQE") > Signed-off-by: Zhu Yanjun <yanjunz@nvidia.com> > --- > .../ethernet/mellanox/mlx5/core/eswitch_offloads.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git > a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c > b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c > index 1bcf260..35c5629 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c > @@ -1528,7 +1528,6 @@ static int esw_create_restore_table(struct > mlx5_eswitch *esw) > goto out_free; > } > > - memset(flow_group_in, 0, inlen); > match_criteria = MLX5_ADDR_OF(create_flow_group_in, > flow_group_in, > match_criteria); > misc = MLX5_ADDR_OF(fte_match_param, match_criteria, applied to net-next-mlx5, Thank you !
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c index 1bcf260..35c5629 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c @@ -1528,7 +1528,6 @@ static int esw_create_restore_table(struct mlx5_eswitch *esw) goto out_free; } - memset(flow_group_in, 0, inlen); match_criteria = MLX5_ADDR_OF(create_flow_group_in, flow_group_in, match_criteria); misc = MLX5_ADDR_OF(fte_match_param, match_criteria,
Since kvzalloc will initialize the allocated memory, it is not necessary to initialize it once again. Fixes: 11b717d61526 ("net/mlx5: E-Switch, Get reg_c0 value on CQE") Signed-off-by: Zhu Yanjun <yanjunz@nvidia.com> --- .../ethernet/mellanox/mlx5/core/eswitch_offloads.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)