| Message ID | 1610531059-56212-1-git-send-email-abaci-bugfix@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net/bridge: Fix inconsistent format argument types | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 24 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On 13/01/2021 11:44, Jiapeng Zhong wrote: > Fix the following warnings: > > net/bridge/br_sysfs_if.c(162): warning: %ld in format string (no. 1) > requires 'long' but the argument type is 'unsigned long'. > net/bridge/br_sysfs_if.c(155): warning: %ld in format string (no. 1) > requires 'long' but the argument type is 'unsigned long'. > net/bridge/br_sysfs_if.c(148): warning: %ld in format string (no. 1) > requires 'long' but the argument type is 'unsigned long'. > > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> > Reported-by: Abaci Robot<abaci@linux.alibaba.com> > --- > net/bridge/br_sysfs_if.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > As I replied to your other patch with the same subject please squash them together and send them targeted at net-next. Thanks. > diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c > index 7a59cdd..16a7d41 100644 > --- a/net/bridge/br_sysfs_if.c > +++ b/net/bridge/br_sysfs_if.c > @@ -145,21 +145,21 @@ static ssize_t show_port_state(struct net_bridge_port *p, char *buf) > static ssize_t show_message_age_timer(struct net_bridge_port *p, > char *buf) > { > - return sprintf(buf, "%ld\n", br_timer_value(&p->message_age_timer)); > + return sprintf(buf, "%lu\n", br_timer_value(&p->message_age_timer)); > } > static BRPORT_ATTR(message_age_timer, 0444, show_message_age_timer, NULL); > > static ssize_t show_forward_delay_timer(struct net_bridge_port *p, > char *buf) > { > - return sprintf(buf, "%ld\n", br_timer_value(&p->forward_delay_timer)); > + return sprintf(buf, "%lu\n", br_timer_value(&p->forward_delay_timer)); > } > static BRPORT_ATTR(forward_delay_timer, 0444, show_forward_delay_timer, NULL); > > static ssize_t show_hold_timer(struct net_bridge_port *p, > char *buf) > { > - return sprintf(buf, "%ld\n", br_timer_value(&p->hold_timer)); > + return sprintf(buf, "%lu\n", br_timer_value(&p->hold_timer)); > } > static BRPORT_ATTR(hold_timer, 0444, show_hold_timer, NULL); > >
diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c index 7a59cdd..16a7d41 100644 --- a/net/bridge/br_sysfs_if.c +++ b/net/bridge/br_sysfs_if.c @@ -145,21 +145,21 @@ static ssize_t show_port_state(struct net_bridge_port *p, char *buf) static ssize_t show_message_age_timer(struct net_bridge_port *p, char *buf) { - return sprintf(buf, "%ld\n", br_timer_value(&p->message_age_timer)); + return sprintf(buf, "%lu\n", br_timer_value(&p->message_age_timer)); } static BRPORT_ATTR(message_age_timer, 0444, show_message_age_timer, NULL); static ssize_t show_forward_delay_timer(struct net_bridge_port *p, char *buf) { - return sprintf(buf, "%ld\n", br_timer_value(&p->forward_delay_timer)); + return sprintf(buf, "%lu\n", br_timer_value(&p->forward_delay_timer)); } static BRPORT_ATTR(forward_delay_timer, 0444, show_forward_delay_timer, NULL); static ssize_t show_hold_timer(struct net_bridge_port *p, char *buf) { - return sprintf(buf, "%ld\n", br_timer_value(&p->hold_timer)); + return sprintf(buf, "%lu\n", br_timer_value(&p->hold_timer)); } static BRPORT_ATTR(hold_timer, 0444, show_hold_timer, NULL);
Fix the following warnings: net/bridge/br_sysfs_if.c(162): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. net/bridge/br_sysfs_if.c(155): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. net/bridge/br_sysfs_if.c(148): warning: %ld in format string (no. 1) requires 'long' but the argument type is 'unsigned long'. Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> Reported-by: Abaci Robot<abaci@linux.alibaba.com> --- net/bridge/br_sysfs_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)