diff mbox series

[v9,net-next,01/15] doc: marvell: add CM3 address space and PPv2.3 description

Message ID 1612723137-18045-2-git-send-email-stefanc@marvell.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series net: mvpp2: Add TX Flow Control support | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for net-next
netdev/subject_prefix success Link
netdev/cc_maintainers success CCed 7 of 7 maintainers
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 22 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link
netdev/stable success Stable not CCed

Commit Message

Stefan Chulski Feb. 7, 2021, 6:38 p.m. UTC
From: Stefan Chulski <stefanc@marvell.com>

Patch adds CM3 address space PPv2.3 description.

Signed-off-by: Stefan Chulski <stefanc@marvell.com>
---
 Documentation/devicetree/bindings/net/marvell-pp2.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Andrew Lunn Feb. 7, 2021, 9:30 p.m. UTC | #1
On Sun, Feb 07, 2021 at 08:38:43PM +0200, stefanc@marvell.com wrote:
> From: Stefan Chulski <stefanc@marvell.com>
> 
> Patch adds CM3 address space PPv2.3 description.
> 
> Signed-off-by: Stefan Chulski <stefanc@marvell.com>
> ---
>  Documentation/devicetree/bindings/net/marvell-pp2.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/marvell-pp2.txt b/Documentation/devicetree/bindings/net/marvell-pp2.txt
> index b783976..1eb480a 100644
> --- a/Documentation/devicetree/bindings/net/marvell-pp2.txt
> +++ b/Documentation/devicetree/bindings/net/marvell-pp2.txt
> @@ -1,5 +1,6 @@
>  * Marvell Armada 375 Ethernet Controller (PPv2.1)
>    Marvell Armada 7K/8K Ethernet Controller (PPv2.2)
> +  Marvell CN913X Ethernet Controller (PPv2.3)
>  
>  Required properties:
>  
> @@ -12,7 +13,7 @@ Required properties:
>  	- common controller registers
>  	- LMS registers
>  	- one register area per Ethernet port
> -  For "marvell,armada-7k-pp2", must contain the following register
> +  For "marvell,armada-7k-pp2" used by 7K/8K and CN913X, must contain the following register
>    sets:
>  	- packet processor registers
>  	- networking interfaces registers

Hi Stefan

Shouldn't there be an entry here describing what the third register
set is?
Stefan Chulski Feb. 7, 2021, 11:38 p.m. UTC | #2
> > @@ -12,7 +13,7 @@ Required properties:
> >  	- common controller registers
> >  	- LMS registers
> >  	- one register area per Ethernet port
> > -  For "marvell,armada-7k-pp2", must contain the following register
> > +  For "marvell,armada-7k-pp2" used by 7K/8K and CN913X, must contain
> > + the following register
> >    sets:
> >  	- packet processor registers
> >  	- networking interfaces registers
> 
> Hi Stefan
> 
> Shouldn't there be an entry here describing what the third register set is?

Would add it in next patchset.

Thanks,
Stefan.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/marvell-pp2.txt b/Documentation/devicetree/bindings/net/marvell-pp2.txt
index b783976..1eb480a 100644
--- a/Documentation/devicetree/bindings/net/marvell-pp2.txt
+++ b/Documentation/devicetree/bindings/net/marvell-pp2.txt
@@ -1,5 +1,6 @@ 
 * Marvell Armada 375 Ethernet Controller (PPv2.1)
   Marvell Armada 7K/8K Ethernet Controller (PPv2.2)
+  Marvell CN913X Ethernet Controller (PPv2.3)
 
 Required properties:
 
@@ -12,7 +13,7 @@  Required properties:
 	- common controller registers
 	- LMS registers
 	- one register area per Ethernet port
-  For "marvell,armada-7k-pp2", must contain the following register
+  For "marvell,armada-7k-pp2" used by 7K/8K and CN913X, must contain the following register
   sets:
 	- packet processor registers
 	- networking interfaces registers
@@ -81,7 +82,7 @@  Example for marvell,armada-7k-pp2:
 
 cpm_ethernet: ethernet@0 {
 	compatible = "marvell,armada-7k-pp22";
-	reg = <0x0 0x100000>, <0x129000 0xb000>;
+	reg = <0x0 0x100000>, <0x129000 0xb000>, <0x220000 0x800>;
 	clocks = <&cpm_syscon0 1 3>, <&cpm_syscon0 1 9>,
 		 <&cpm_syscon0 1 5>, <&cpm_syscon0 1 6>, <&cpm_syscon0 1 18>;
 	clock-names = "pp_clk", "gop_clk", "mg_clk", "mg_core_clk", "axi_clk";