| Message ID | 1613640279-56480-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | BPF |
| Headers | show |
| Series | perf machine: Use true and false for bool variable | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 2/18/21 2:54 PM, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./tools/perf/util/machine.c:2000:9-10: WARNING: return of 0/1 in > function 'symbol__match_regex' with return type bool. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > tools/perf/util/machine.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index 1e9d3f9..f7ee29b 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -1997,8 +1997,8 @@ int machine__process_event(struct machine *machine, union perf_event *event, > static bool symbol__match_regex(struct symbol *sym, regex_t *regex) > { > if (!regexec(regex, sym->name, 0, NULL, 0)) > - return 1; > - return 0; > + return true; > + return false; > } > Hi Jiapeng, Just a suggestion, Can we make this check in single line like this: static bool symbol__match_regex(struct symbol *sym, regex_t *regex) { return regexec(regex, sym->name, 0, NULL, 0) == 0; } Thanks, Kajol Jain > static void ip__resolve_ams(struct thread *thread, >
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index 1e9d3f9..f7ee29b 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -1997,8 +1997,8 @@ int machine__process_event(struct machine *machine, union perf_event *event, static bool symbol__match_regex(struct symbol *sym, regex_t *regex) { if (!regexec(regex, sym->name, 0, NULL, 0)) - return 1; - return 0; + return true; + return false; } static void ip__resolve_ams(struct thread *thread,
Fix the following coccicheck warnings: ./tools/perf/util/machine.c:2000:9-10: WARNING: return of 0/1 in function 'symbol__match_regex' with return type bool. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- tools/perf/util/machine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)