| Message ID | 1615346305-16428-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | BPF |
| Headers | show |
| Series | perf tools: Remove redundant code | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 3/10/21 8:48 AM, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./tools/perf/util/evlist.c:1315:5-8: Unneeded variable: "err". Return "- > ENOMEM" on line 1340. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > tools/perf/util/evlist.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index 882cd1f..6c2a271 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -1313,7 +1313,6 @@ static int evlist__create_syswide_maps(struct evlist *evlist) > { > struct perf_cpu_map *cpus; > struct perf_thread_map *threads; > - int err = -ENOMEM; > > /* > * Try reading /sys/devices/system/cpu/online to get > @@ -1338,7 +1337,7 @@ static int evlist__create_syswide_maps(struct evlist *evlist) > out_put: > perf_cpu_map__put(cpus); > out: > - return err; > + return -ENOMEM; > } Seems fine to me. Reviewed-By: Kajol Jain<kjain@linux.ibm.com> Thanks, Kajol Jain > > int evlist__open(struct evlist *evlist) >
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index 882cd1f..6c2a271 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c @@ -1313,7 +1313,6 @@ static int evlist__create_syswide_maps(struct evlist *evlist) { struct perf_cpu_map *cpus; struct perf_thread_map *threads; - int err = -ENOMEM; /* * Try reading /sys/devices/system/cpu/online to get @@ -1338,7 +1337,7 @@ static int evlist__create_syswide_maps(struct evlist *evlist) out_put: perf_cpu_map__put(cpus); out: - return err; + return -ENOMEM; } int evlist__open(struct evlist *evlist)
Fix the following coccicheck warnings: ./tools/perf/util/evlist.c:1315:5-8: Unneeded variable: "err". Return "- ENOMEM" on line 1340. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- tools/perf/util/evlist.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)