| Message ID | 1616982313-14119-1-git-send-email-huangguobin4@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a956b21596f300506d20dd9d2a2a039772193a8f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v2] net: axienet: Remove redundant dev_err call in axienet_probe() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 7 this patch: 7 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 7 this patch: 7 |
| netdev/header_inline | success | Link |
On 3/29/21 3:45 AM, Huang Guobin wrote: > From: Guobin Huang <huangguobin4@huawei.com> > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Guobin Huang <huangguobin4@huawei.com> > --- > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > index 5d677db0aee5..f77a794540fc 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > @@ -1878,7 +1878,6 @@ static int axienet_probe(struct platform_device *pdev) > ethres = platform_get_resource(pdev, IORESOURCE_MEM, 0); > lp->regs = devm_ioremap_resource(&pdev->dev, ethres); > if (IS_ERR(lp->regs)) { > - dev_err(&pdev->dev, "could not map Axi Ethernet regs.\n"); > ret = PTR_ERR(lp->regs); > goto cleanup_clk; > } > I have already reviewed v1 and I can't see any v2 description what has changed. Why am I getting this v2? Where is my tag? Thanks, Michal
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 29 Mar 2021 09:45:13 +0800 you wrote: > From: Guobin Huang <huangguobin4@huawei.com> > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Guobin Huang <huangguobin4@huawei.com> > > [...] Here is the summary with links: - [net-next,v2] net: axienet: Remove redundant dev_err call in axienet_probe() https://git.kernel.org/netdev/net-next/c/a956b21596f3 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 5d677db0aee5..f77a794540fc 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1878,7 +1878,6 @@ static int axienet_probe(struct platform_device *pdev) ethres = platform_get_resource(pdev, IORESOURCE_MEM, 0); lp->regs = devm_ioremap_resource(&pdev->dev, ethres); if (IS_ERR(lp->regs)) { - dev_err(&pdev->dev, "could not map Axi Ethernet regs.\n"); ret = PTR_ERR(lp->regs); goto cleanup_clk; }