From patchwork Sat Apr 24 20:14:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 12222763 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MIME_HEADER_CTYPE_ONLY, SPF_HELO_NONE,SPF_PASS,T_TVD_MIME_NO_HEADERS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C33EAC433B4 for ; Sat, 24 Apr 2021 20:14:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EC5F61474 for ; Sat, 24 Apr 2021 20:14:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236355AbhDXUPX (ORCPT ); Sat, 24 Apr 2021 16:15:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233563AbhDXUPW (ORCPT ); Sat, 24 Apr 2021 16:15:22 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D1C1C061574 for ; Sat, 24 Apr 2021 13:14:44 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id j7so28099489pgi.3 for ; Sat, 24 Apr 2021 13:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6H8VOL+zkYYPi1vUZJacnC7u1O0papi4ihkOtJ+wYiI=; b=S2TtQirVzzZB2eME2Mp3QN+ffmlpIlEiGquNjEoeXsdCgFdSBvwuj5XbamWgJZw1LK Brcm6PM6DyPGUsncz+3nz7lauVC8WurPua4UMmVoBUXA0nSykZA63gc6MVJ0zMQeZoeq 3unmS10Y9h/NmQgeLz7uyaY6rq1N5Ab+EnF74= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6H8VOL+zkYYPi1vUZJacnC7u1O0papi4ihkOtJ+wYiI=; b=jPsg8O7PfS/hY/XG896tIWbJTzh3R1WTbpG2W9m3jY9DMZdQsqPS+F2oIygk5R3dHY msUFdV6eqbJRY1XqnqYGmURhHSDzHV/aqkVWfh0IFmPPF82sQ9np/qsF2DHPKEEpxJov Qtjh9emecbQlTMrLng/yxndQ+p+xZ48x2tT/GWMj3qPL44Jz9DQDH1oeuIsOPiIAeF8g Og3BPoxgr0HOIxi9YRjPvivF+UJJjv3ZoT4ghtSDN3ms7sr+CAQqlQ7tggNLJBeadf8p q4+VvEfw9vfLglU5lfY+FDuW8ZxD19PYZki+V9jBljc9gvftTvArXc7GCEspkLX274xr ZTRA== X-Gm-Message-State: AOAM5332MOAdkLKfyXYX4Yfb3HqnXaFDHChdT82/A7BukUJxEIMXYEOB icgjGD4gM36DqZrQsa+KD9eF1/eNM7heYANe X-Google-Smtp-Source: ABdhPJxZcVqDQSs7/aaOXytnHOgo1NBvuN71iCqfSaGn3CW0wOl90uoVy67jFZ5mQSQ5M3y9bvOu8g== X-Received: by 2002:a62:dd41:0:b029:24c:27a4:48f1 with SMTP id w62-20020a62dd410000b029024c27a448f1mr9883175pff.42.1619295283321; Sat, 24 Apr 2021 13:14:43 -0700 (PDT) Received: from localhost.swdvt.lab.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id z29sm7914070pga.52.2021.04.24.13.14.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Apr 2021 13:14:42 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, kuba@kernel.org, gospo@broadcom.com Subject: [PATCH net-next 01/10] bnxt_en: report signal mode in link up messages Date: Sat, 24 Apr 2021 16:14:22 -0400 Message-Id: <1619295271-30853-2-git-send-email-michael.chan@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1619295271-30853-1-git-send-email-michael.chan@broadcom.com> References: <1619295271-30853-1-git-send-email-michael.chan@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Edwin Peer Firmware reports link signalling mode for certain speeds. In these cases, print the signalling modes in kernel log link up messages. Reviewed-by: Andy Gospodarek Signed-off-by: Edwin Peer Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index e15d454e33f0..573c039e6046 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -9075,8 +9075,9 @@ static char *bnxt_report_fec(struct bnxt_link_info *link_info) static void bnxt_report_link(struct bnxt *bp) { if (bp->link_info.link_up) { - const char *duplex; + const char *signal = ""; const char *flow_ctrl; + const char *duplex; u32 speed; u16 fec; @@ -9098,8 +9099,23 @@ static void bnxt_report_link(struct bnxt *bp) flow_ctrl = "ON - receive"; else flow_ctrl = "none"; - netdev_info(bp->dev, "NIC Link is Up, %u Mbps %s duplex, Flow control: %s\n", - speed, duplex, flow_ctrl); + if (bp->link_info.phy_qcfg_resp.option_flags & + PORT_PHY_QCFG_RESP_OPTION_FLAGS_SIGNAL_MODE_KNOWN) { + u8 sig_mode = bp->link_info.active_fec_sig_mode & + PORT_PHY_QCFG_RESP_SIGNAL_MODE_MASK; + switch (sig_mode) { + case PORT_PHY_QCFG_RESP_SIGNAL_MODE_NRZ: + signal = "(NRZ) "; + break; + case PORT_PHY_QCFG_RESP_SIGNAL_MODE_PAM4: + signal = "(PAM4) "; + break; + default: + break; + } + } + netdev_info(bp->dev, "NIC Link is Up, %u Mbps %s%s duplex, Flow control: %s\n", + speed, signal, duplex, flow_ctrl); if (bp->flags & BNXT_FLAG_EEE_CAP) netdev_info(bp->dev, "EEE is %s\n", bp->eee.eee_active ? "active" :