| Message ID | 1619347023-49996-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | cxgb4: Remove redundant assignment to ret | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 3 maintainers not CCed: nathan@kernel.org ndesaulniers@google.com clang-built-linux@googlegroups.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 2 this patch: 2 |
| netdev/kdoc | success | Errors and warnings before: 2 this patch: 2 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 2 this patch: 2 |
| netdev/header_inline | success | Link |
On Sunday, April 04/25/21, 2021 at 18:37:03 +0800, Jiapeng Chong wrote: > Variable ret is set to zero but this value is never read as it is > overwritten with a new value later on, hence it is a redundant > assignment and can be removed. > > Cleans up the following clang-analyzer warning: > > drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:3830:2: warning: Value stored > to 'ret' is never read [clang-analyzer-deadcode.DeadStores]. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c > index 80882cf..b9d2d58 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c > +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c > @@ -3827,8 +3827,8 @@ int t4_load_phy_fw(struct adapter *adap, int win, > FW_PARAMS_PARAM_X_V(FW_PARAMS_PARAM_DEV_PHYFW) | > FW_PARAMS_PARAM_Y_V(adap->params.portvec) | > FW_PARAMS_PARAM_Z_V(FW_PARAMS_PARAM_DEV_PHYFW_DOWNLOAD)); > - ret = t4_set_params_timeout(adap, adap->mbox, adap->pf, 0, 1, > - ¶m, &val, 30000); Thanks for reporting this. However, the return value of t4_set_params_timeout() needs to be handled and can not be ignored. Will send a patch to fix the issue soon. > + t4_set_params_timeout(adap, adap->mbox, adap->pf, 0, 1, > + ¶m, &val, 30000); > > /* If we have version number support, then check to see that the new > * firmware got loaded properly. > -- > 1.8.3.1 >
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index 80882cf..b9d2d58 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c @@ -3827,8 +3827,8 @@ int t4_load_phy_fw(struct adapter *adap, int win, FW_PARAMS_PARAM_X_V(FW_PARAMS_PARAM_DEV_PHYFW) | FW_PARAMS_PARAM_Y_V(adap->params.portvec) | FW_PARAMS_PARAM_Z_V(FW_PARAMS_PARAM_DEV_PHYFW_DOWNLOAD)); - ret = t4_set_params_timeout(adap, adap->mbox, adap->pf, 0, 1, - ¶m, &val, 30000); + t4_set_params_timeout(adap, adap->mbox, adap->pf, 0, 1, + ¶m, &val, 30000); /* If we have version number support, then check to see that the new * firmware got loaded properly.
Variable ret is set to zero but this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removed. Cleans up the following clang-analyzer warning: drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:3830:2: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)