| Message ID | 1619604330-122462-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | nfp: flower: Remove redundant assignment to mask | expand |
On Wed, 28 Apr 2021 18:05:30 +0800 Jiapeng Chong wrote: > The value stored to mask in the calculations this patch removes is > not used, so the calculation and the assignment can be removed. > > Cleans up the following clang-analyzer warning: > > drivers/net/ethernet/netronome/nfp/flower/offload.c:1230:3: warning: > Value stored to 'mask' is never read > [clang-analyzer-deadcode.DeadStores]. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Seems cleaner to always move ext and mask, in case some code is added later in the function and starts accessing mask.
diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c b/drivers/net/ethernet/netronome/nfp/flower/offload.c index e95969c..86e734a 100644 --- a/drivers/net/ethernet/netronome/nfp/flower/offload.c +++ b/drivers/net/ethernet/netronome/nfp/flower/offload.c @@ -1227,7 +1227,6 @@ int nfp_flower_merge_offloaded_flows(struct nfp_app *app, return -EOPNOTSUPP; } ext += size; - mask += size; } if ((priv->flower_ext_feats & NFP_FL_FEATS_VLAN_QINQ)) {
The value stored to mask in the calculations this patch removes is not used, so the calculation and the assignment can be removed. Cleans up the following clang-analyzer warning: drivers/net/ethernet/netronome/nfp/flower/offload.c:1230:3: warning: Value stored to 'mask' is never read [clang-analyzer-deadcode.DeadStores]. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/net/ethernet/netronome/nfp/flower/offload.c | 1 - 1 file changed, 1 deletion(-)