diff mbox series

[net-next,7/8] net: phy: remove unnecessary line continuation

Message ID 1623393419-2521-8-git-send-email-liweihang@huawei.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series net: phy: fix some coding-style issues | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for net-next
netdev/subject_prefix success Link
netdev/cc_maintainers warning 2 maintainers not CCed: richardcochran@gmail.com linux@armlinux.org.uk
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch warning CHECK: Alignment should match open parenthesis
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link

Commit Message

Weihang Li June 11, 2021, 6:36 a.m. UTC 
From: Wenpeng Liang <liangwenpeng@huawei.com>

Avoid unnecessary line continuations.

Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
Signed-off-by: Weihang Li <liweihang@huawei.com>
---
 drivers/net/phy/dp83640.c | 4 ++--
 drivers/net/phy/et1011c.c | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

Comments

Andrew Lunn June 11, 2021, 4:06 p.m. UTC | #1 
> -			phy_write(phydev, ET1011C_CONFIG_REG, val\
> -					| ET1011C_GMII_INTERFACE\
> -					| ET1011C_SYS_CLK_EN\
> +			phy_write(phydev, ET1011C_CONFIG_REG, val
> +					| ET1011C_GMII_INTERFACE
> +					| ET1011C_SYS_CLK_EN
>  					| ET1011C_TX_FIFO_DEPTH_16);

Please put the | at the end of the line, not the beginning of the next
line.

Thanks
	Andrew
Weihang Li June 15, 2021, 6:26 a.m. UTC | #2 
On 2021/6/12 0:07, Andrew Lunn wrote:
>> -			phy_write(phydev, ET1011C_CONFIG_REG, val\
>> -					| ET1011C_GMII_INTERFACE\
>> -					| ET1011C_SYS_CLK_EN\
>> +			phy_write(phydev, ET1011C_CONFIG_REG, val
>> +					| ET1011C_GMII_INTERFACE
>> +					| ET1011C_SYS_CLK_EN
>>  					| ET1011C_TX_FIFO_DEPTH_16);
> 
> Please put the | at the end of the line, not the beginning of the next
> line.
> 
> Thanks
> 	Andrew
> 

Sure, thank you.

Weihang
diff mbox series

Patch

diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index 10769bf..705c166 100644
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -170,9 +170,9 @@  static ushort gpio_tab[GPIO_TABLE_SIZE] = {
 module_param(chosen_phy, int, 0444);
 module_param_array(gpio_tab, ushort, NULL, 0444);
 
-MODULE_PARM_DESC(chosen_phy, \
+MODULE_PARM_DESC(chosen_phy,
 	"The address of the PHY to use for the ancillary clock features");
-MODULE_PARM_DESC(gpio_tab, \
+MODULE_PARM_DESC(gpio_tab,
 	"Which GPIO line to use for which purpose: cal,perout,extts1,...,extts6");
 
 static void dp83640_gpio_defaults(struct ptp_pin_desc *pd)
diff --git a/drivers/net/phy/et1011c.c b/drivers/net/phy/et1011c.c
index 4b3d035..72f51b7 100644
--- a/drivers/net/phy/et1011c.c
+++ b/drivers/net/phy/et1011c.c
@@ -74,9 +74,9 @@  static int et1011c_read_status(struct phy_device *phydev)
 					ET1011C_GIGABIT_SPEED) {
 			val = phy_read(phydev, ET1011C_CONFIG_REG);
 			val &= ~ET1011C_TX_FIFO_MASK;
-			phy_write(phydev, ET1011C_CONFIG_REG, val\
-					| ET1011C_GMII_INTERFACE\
-					| ET1011C_SYS_CLK_EN\
+			phy_write(phydev, ET1011C_CONFIG_REG, val
+					| ET1011C_GMII_INTERFACE
+					| ET1011C_SYS_CLK_EN
 					| ET1011C_TX_FIFO_DEPTH_16);
 
 		}