| Message ID | 1623828340-2019-1-git-send-email-zhangshaokun@hisilicon.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: iosm: remove the repeated declaration and comment | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 1 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 16 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
> Function 'ipc_mmio_get_cp_version' is declared twice, so remove the > repeated declaration and wrong comments. > > Cc: M Chetan Kumar <m.chetan.kumar@intel.com> > Cc: Intel Corporation <linuxwwan@intel.com> > Cc: David S. Miller <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com> > --- > drivers/net/wwan/iosm/iosm_ipc_mmio.h | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/net/wwan/iosm/iosm_ipc_mmio.h > b/drivers/net/wwan/iosm/iosm_ipc_mmio.h > index bcf77aea06e7..45e6923da78f 100644 > --- a/drivers/net/wwan/iosm/iosm_ipc_mmio.h > +++ b/drivers/net/wwan/iosm/iosm_ipc_mmio.h > @@ -121,16 +121,6 @@ void ipc_mmio_set_contex_info_addr(struct > iosm_mmio *ipc_mmio, > phys_addr_t addr); > > /** > - * ipc_mmio_get_cp_version - Write context info and AP memory range > addresses. > - * This needs to be called when CP is in > - * IPC_MEM_DEVICE_IPC_INIT state > - * @ipc_mmio: Pointer to mmio instance > - * > - * Returns: cp version else failure value on error > - */ > -int ipc_mmio_get_cp_version(struct iosm_mmio *ipc_mmio); > - > -/** > * ipc_mmio_get_cp_version - Get the CP IPC version > * @ipc_mmio: Pointer to mmio instance > * > -- > 2.7.4 Thanks, Reviewed-by: M Chetan Kumar <m.chetan.kumar@intel.com>
diff --git a/drivers/net/wwan/iosm/iosm_ipc_mmio.h b/drivers/net/wwan/iosm/iosm_ipc_mmio.h index bcf77aea06e7..45e6923da78f 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_mmio.h +++ b/drivers/net/wwan/iosm/iosm_ipc_mmio.h @@ -121,16 +121,6 @@ void ipc_mmio_set_contex_info_addr(struct iosm_mmio *ipc_mmio, phys_addr_t addr); /** - * ipc_mmio_get_cp_version - Write context info and AP memory range addresses. - * This needs to be called when CP is in - * IPC_MEM_DEVICE_IPC_INIT state - * @ipc_mmio: Pointer to mmio instance - * - * Returns: cp version else failure value on error - */ -int ipc_mmio_get_cp_version(struct iosm_mmio *ipc_mmio); - -/** * ipc_mmio_get_cp_version - Get the CP IPC version * @ipc_mmio: Pointer to mmio instance *
Function 'ipc_mmio_get_cp_version' is declared twice, so remove the repeated declaration and wrong comments. Cc: M Chetan Kumar <m.chetan.kumar@intel.com> Cc: Intel Corporation <linuxwwan@intel.com> Cc: David S. Miller <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com> --- drivers/net/wwan/iosm/iosm_ipc_mmio.h | 10 ---------- 1 file changed, 10 deletions(-)