| Message ID | 1634280624-4816-1-git-send-email-wangqing@vivo.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: can: replace snprintf in show functions with sysfs_emit | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
On 14.10.2021 23:50:24, Qing Wang wrote: > show() must not use snprintf() when formatting the value to be > returned to user space. > > Fix the following coccicheck warning: > drivers/net/can/at91_can.c:1185: WARNING: use scnprintf or sprintf. > drivers/net/can/janz-ican3.c:1834: WARNING: use scnprintf or sprintf. > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > > Signed-off-by: Qing Wang <wangqing@vivo.com> Added to linux-can-next/testing. Thanks, Marc
diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c index 04d0bb3..e4e754e 100644 --- a/drivers/net/can/at91_can.c +++ b/drivers/net/can/at91_can.c @@ -1182,9 +1182,9 @@ static ssize_t at91_sysfs_show_mb0_id(struct device *dev, struct at91_priv *priv = netdev_priv(to_net_dev(dev)); if (priv->mb0_id & CAN_EFF_FLAG) - return snprintf(buf, PAGE_SIZE, "0x%08x\n", priv->mb0_id); + return sysfs_emit(buf, "0x%08x\n", priv->mb0_id); else - return snprintf(buf, PAGE_SIZE, "0x%03x\n", priv->mb0_id); + return sysfs_emit(buf, "0x%03x\n", priv->mb0_id); } static ssize_t at91_sysfs_set_mb0_id(struct device *dev, diff --git a/drivers/net/can/janz-ican3.c b/drivers/net/can/janz-ican3.c index 2a6c918..feedc13 100644 --- a/drivers/net/can/janz-ican3.c +++ b/drivers/net/can/janz-ican3.c @@ -1831,7 +1831,7 @@ static ssize_t ican3_sysfs_show_term(struct device *dev, return -ETIMEDOUT; } - return snprintf(buf, PAGE_SIZE, "%u\n", mod->termination_enabled); + return sysfs_emit(buf, "%u\n", mod->termination_enabled); } static ssize_t ican3_sysfs_set_term(struct device *dev,
show() must not use snprintf() when formatting the value to be returned to user space. Fix the following coccicheck warning: drivers/net/can/at91_can.c:1185: WARNING: use scnprintf or sprintf. drivers/net/can/janz-ican3.c:1834: WARNING: use scnprintf or sprintf. Use sysfs_emit instead of scnprintf or sprintf makes more sense. Signed-off-by: Qing Wang <wangqing@vivo.com> --- drivers/net/can/at91_can.c | 4 ++-- drivers/net/can/janz-ican3.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)