| Message ID | 1636969507-39355-1-git-send-email-guwen@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cf4f5530bb55ef7d5a91036b26676643b80b1616 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net/smc: Make sure the link_id is unique | expand |
On 15/11/2021 10:45, Wen Gu wrote: > The link_id is supposed to be unique, but smcr_next_link_id() doesn't > skip the used link_id as expected. So the patch fixes this. > > Fixes: 026c381fb477 ("net/smc: introduce link_idx for link group array") > Signed-off-by: Wen Gu <guwen@linux.alibaba.com> > Reviewed-by: Tony Lu <tonylu@linux.alibaba.com> > --- Thank you. Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Mon, 15 Nov 2021 17:45:07 +0800 you wrote: > The link_id is supposed to be unique, but smcr_next_link_id() doesn't > skip the used link_id as expected. So the patch fixes this. > > Fixes: 026c381fb477 ("net/smc: introduce link_idx for link group array") > Signed-off-by: Wen Gu <guwen@linux.alibaba.com> > Reviewed-by: Tony Lu <tonylu@linux.alibaba.com> > > [...] Here is the summary with links: - [net] net/smc: Make sure the link_id is unique https://git.kernel.org/netdev/net/c/cf4f5530bb55 You are awesome, thank you!
diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c index 49b8ba3..25ebd30 100644 --- a/net/smc/smc_core.c +++ b/net/smc/smc_core.c @@ -708,13 +708,14 @@ static u8 smcr_next_link_id(struct smc_link_group *lgr) int i; while (1) { +again: link_id = ++lgr->next_link_id; if (!link_id) /* skip zero as link_id */ link_id = ++lgr->next_link_id; for (i = 0; i < SMC_LINKS_PER_LGR_MAX; i++) { if (smc_link_usable(&lgr->lnk[i]) && lgr->lnk[i].link_id == link_id) - continue; + goto again; } break; }
The link_id is supposed to be unique, but smcr_next_link_id() doesn't skip the used link_id as expected. So the patch fixes this. Fixes: 026c381fb477 ("net/smc: introduce link_idx for link group array") Signed-off-by: Wen Gu <guwen@linux.alibaba.com> Reviewed-by: Tony Lu <tonylu@linux.alibaba.com> --- net/smc/smc_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)