diff mbox series

[ethtool] ethtool: Set mask correctly for dumping advertised FEC modes

Message ID 163701677432.25599.14085739652121434612.stgit@localhost.localdomain (mailing list archive)
State Accepted
Commit 50fdaec68feb63753137468a28ce992502883f88
Delegated to: Michal Kubecek
Headers show
Series [ethtool] ethtool: Set mask correctly for dumping advertised FEC modes | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Alexander Duyck Nov. 15, 2021, 10:52 p.m. UTC 
From: Alexander Duyck <alexanderduyck@fb.com>

Set the "mask" value to false when dumping the advertised FEC modes.
The advertised values are stored in the value field, while the supported
values are what is stored in the mask.

Without this change the supported value is displayed for both the supported
and advertised modes resulting in the advertised value being ignored.

Signed-off-by: Alexander Duyck <alexanderduyck@fb.com>
---
 netlink/settings.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Nov. 21, 2021, 11:20 p.m. UTC | #1 
Hello:

This patch was applied to ethtool/ethtool.git (master)
by Michal Kubecek <mkubecek@suse.cz>:

On Mon, 15 Nov 2021 14:52:54 -0800 you wrote:
> From: Alexander Duyck <alexanderduyck@fb.com>
> 
> Set the "mask" value to false when dumping the advertised FEC modes.
> The advertised values are stored in the value field, while the supported
> values are what is stored in the mask.
> 
> Without this change the supported value is displayed for both the supported
> and advertised modes resulting in the advertised value being ignored.
> 
> [...]

Here is the summary with links:
  - [ethtool] ethtool: Set mask correctly for dumping advertised FEC modes
    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=50fdaec68feb

You are awesome, thank you!
diff mbox series

Patch

diff --git a/netlink/settings.c b/netlink/settings.c
index c4f5d61923aa..ff1e783d099c 100644
--- a/netlink/settings.c
+++ b/netlink/settings.c
@@ -402,7 +402,7 @@  static int dump_our_modes(struct nl_context *nlctx, const struct nlattr *attr)
 		return ret;
 	printf("\tAdvertised auto-negotiation: %s\n", autoneg ? "Yes" : "No");
 
-	ret = dump_link_modes(nlctx, attr, true, LM_CLASS_FEC,
+	ret = dump_link_modes(nlctx, attr, false, LM_CLASS_FEC,
 			      "Advertised FEC modes: ", " ", "\n",
 			      "Not reported");
 	return ret;