| Message ID | 1637721384-70836-2-git-send-email-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next,1/2] tsnep: fix resource_size.cocci warnings | expand |
> > Remove .owner field if calls are used which set it automatically > > Eliminate the following coccicheck warning: > ./drivers/net/ethernet/engleder/tsnep_main.c:1263:3-8: No need to set > .owner here. The core will do it. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/net/ethernet/engleder/tsnep_main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c > index c48e8ea..3d0408e 100644 > --- a/drivers/net/ethernet/engleder/tsnep_main.c > +++ b/drivers/net/ethernet/engleder/tsnep_main.c > @@ -1260,7 +1260,6 @@ static int tsnep_remove(struct platform_device *pdev) > static struct platform_driver tsnep_driver = { > .driver = { > .name = TSNEP, > - .owner = THIS_MODULE, > .of_match_table = of_match_ptr(tsnep_of_match), > }, > .probe = tsnep_probe, > -- > 1.8.3.1 > Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
On Wed, 24 Nov 2021 21:32:27 +0100 Gerhard Engleder wrote: > > > > Remove .owner field if calls are used which set it automatically > > > > Eliminate the following coccicheck warning: > > ./drivers/net/ethernet/engleder/tsnep_main.c:1263:3-8: No need to set > > .owner here. The core will do it. > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > > Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com> Applied this one and took Gerhard's patch for the resource size thing. Thanks!
diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c index c48e8ea..3d0408e 100644 --- a/drivers/net/ethernet/engleder/tsnep_main.c +++ b/drivers/net/ethernet/engleder/tsnep_main.c @@ -1260,7 +1260,6 @@ static int tsnep_remove(struct platform_device *pdev) static struct platform_driver tsnep_driver = { .driver = { .name = TSNEP, - .owner = THIS_MODULE, .of_match_table = of_match_ptr(tsnep_of_match), }, .probe = tsnep_probe,
Remove .owner field if calls are used which set it automatically Eliminate the following coccicheck warning: ./drivers/net/ethernet/engleder/tsnep_main.c:1263:3-8: No need to set .owner here. The core will do it. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/net/ethernet/engleder/tsnep_main.c | 1 - 1 file changed, 1 deletion(-)