| Message ID | 1638260517-13634-2-git-send-email-zhuyinbo@loongson.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v3,1/2] modpost: file2alias: make mdio alias configure match mdio uevent | expand |
On Tue, Nov 30, 2021 at 04:21:57PM +0800, Yinbo Zhu wrote: > The of_device_uevent_modalias is service for 'of' type platform driver > , which ask the first args must be 'of' that use MODULE_DEVICE_TABLE > when driver was exported, but ethernet phy is a kind of 'mdio' type > device and it is inappropriate if driver use 'of' type for exporting, > in fact, most mainstream ethernet phy driver hasn't used 'of' type, > even though phy driver was exported use 'of' type and it's irrelevant > with mdio_uevent, at this time, platform_uevent was responsible for > reporting uevent to match modules.alias configure, so, whatever that > of_device_uevent_modalias was unnecessary, this patch was to remove it > and add phy_id as modio uevent then ethernet phy module auto load > function will work well. NAK.
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 6865d93..999f0d4 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -962,12 +962,12 @@ static int mdio_bus_match(struct device *dev, struct device_driver *drv) static int mdio_uevent(struct device *dev, struct kobj_uevent_env *env) { - int rc; + struct phy_device *pdev; - /* Some devices have extra OF data and an OF-style MODALIAS */ - rc = of_device_uevent_modalias(dev, env); - if (rc != -ENODEV) - return rc; + pdev = to_phy_device(dev); + + if (add_uevent_var(env, "MODALIAS=mdio:p%08X", pdev->phy_id)) + return -ENOMEM; return 0; } @@ -991,7 +991,7 @@ static int mdio_uevent(struct device *dev, struct kobj_uevent_env *env) }; struct bus_type mdio_bus_type = { - .name = "mdio_bus", + .name = "mdio", .dev_groups = mdio_bus_dev_groups, .match = mdio_bus_match, .uevent = mdio_uevent,
The of_device_uevent_modalias is service for 'of' type platform driver , which ask the first args must be 'of' that use MODULE_DEVICE_TABLE when driver was exported, but ethernet phy is a kind of 'mdio' type device and it is inappropriate if driver use 'of' type for exporting, in fact, most mainstream ethernet phy driver hasn't used 'of' type, even though phy driver was exported use 'of' type and it's irrelevant with mdio_uevent, at this time, platform_uevent was responsible for reporting uevent to match modules.alias configure, so, whatever that of_device_uevent_modalias was unnecessary, this patch was to remove it and add phy_id as modio uevent then ethernet phy module auto load function will work well. Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> --- Change in v3: Rework the patch commit log information. drivers/net/phy/mdio_bus.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)