| Message ID | 1644921768-26477-1-git-send-email-khoroshilov@ispras.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8c6ae46150a453f8ae9a6cd49b45f354f478587d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: lantiq_gswip: fix use after free in gswip_remove() | expand |
On Tue, Feb 15, 2022 at 01:42:48PM +0300, Alexey Khoroshilov wrote: > of_node_put(priv->ds->slave_mii_bus->dev.of_node) should be > done before mdiobus_free(priv->ds->slave_mii_bus). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> > Fixes: 0d120dfb5d67 ("net: dsa: lantiq_gswip: don't use devres for mdiobus") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 15 Feb 2022 13:42:48 +0300 you wrote: > of_node_put(priv->ds->slave_mii_bus->dev.of_node) should be > done before mdiobus_free(priv->ds->slave_mii_bus). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> > Fixes: 0d120dfb5d67 ("net: dsa: lantiq_gswip: don't use devres for mdiobus") > --- > drivers/net/dsa/lantiq_gswip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - net: dsa: lantiq_gswip: fix use after free in gswip_remove() https://git.kernel.org/netdev/net/c/8c6ae46150a4 You are awesome, thank you!
diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c index 320ee7fe91a8..8a7a8093a156 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -2176,8 +2176,8 @@ static int gswip_remove(struct platform_device *pdev) if (priv->ds->slave_mii_bus) { mdiobus_unregister(priv->ds->slave_mii_bus); - mdiobus_free(priv->ds->slave_mii_bus); of_node_put(priv->ds->slave_mii_bus->dev.of_node); + mdiobus_free(priv->ds->slave_mii_bus); } for (i = 0; i < priv->num_gphy_fw; i++)
of_node_put(priv->ds->slave_mii_bus->dev.of_node) should be done before mdiobus_free(priv->ds->slave_mii_bus). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Fixes: 0d120dfb5d67 ("net: dsa: lantiq_gswip: don't use devres for mdiobus") --- drivers/net/dsa/lantiq_gswip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)