From patchwork Sat Mar 5 08:54:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 12770275 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32497C4332F for ; Sat, 5 Mar 2022 08:55:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230226AbiCEIzy (ORCPT ); Sat, 5 Mar 2022 03:55:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230212AbiCEIzx (ORCPT ); Sat, 5 Mar 2022 03:55:53 -0500 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA7132525B6 for ; Sat, 5 Mar 2022 00:55:04 -0800 (PST) Received: by mail-pf1-x431.google.com with SMTP id j1so5609964pfj.5 for ; Sat, 05 Mar 2022 00:55:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JKbyk4sw44njRI+vPJt6jsM/3N630tpKhlybDHTrgjI=; b=aDgF1pR2eeGy4VtelsKzH/tkkHJNkiD0YLtkfZM/QmlLad4eApE78Gphwh//qnmCXF pxwk0ZCHSJH/hQGVTl6bTMfWSyYWgFeYFopa1/T+JyfuUFdcH5sWGccox1M/YPy2W3I9 ulUuvhRABBefJd9JjrLI8ty+Zj1Gf+TB9uygw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JKbyk4sw44njRI+vPJt6jsM/3N630tpKhlybDHTrgjI=; b=Fe1UM54idaYk8ubRrw/QNOTYIEHZmU2U+IA4DXtryzUlXk7DrZZrZkwXh/EtDR37AG RG9nzLytkLrk1U59qDLBYxllT9H37IcPkN58QM6dBmjfvgc6tPdM0IOKnrX9R1GQR7QF xsHjEAJyavM6bVzzwVSTW3X5dRT6mfvTymSSQe5mejzLOna0AS9t2nhNWQnuIZx0evKg v2aN5/FR3EmnG/ut52cron7XkdClEo8vCZmeTcnvgUZK1zT5zesRC5Jz1s9XdmVCdCKC 4o6JCBmdq3tIGsflISeSulj0/NQkxAJye6Qmylcrr8UIrMREzUGUxr/Mb++LTKnJzECq ZwMQ== X-Gm-Message-State: AOAM533+7np/V1ogMTo/C+2qoGATVUr+kC2zFfRXQvzDiczF2i19yQtY hgNSQmVP+61zl0RvvUp0Z+Z0xg== X-Google-Smtp-Source: ABdhPJwYHR53e2La53OiadSEpdXVedy0qBmj9rT4SRSYbLWxqzykZTUPCn8pbpLes3Nk2u3tRYqFLg== X-Received: by 2002:aa7:909a:0:b0:4e1:6d4:5905 with SMTP id i26-20020aa7909a000000b004e106d45905mr2780740pfa.34.1646470503844; Sat, 05 Mar 2022 00:55:03 -0800 (PST) Received: from localhost.swdvt.lab.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id p28-20020a056a000a1c00b004f6519e61b7sm9213261pfh.21.2022.03.05.00.55.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Mar 2022 00:55:03 -0800 (PST) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, kuba@kernel.org, gospo@broadcom.com Subject: [PATCH net-next 2/9] bnxt_en: add more error checks to HWRM_NVM_INSTALL_UPDATE Date: Sat, 5 Mar 2022 03:54:35 -0500 Message-Id: <1646470482-13763-3-git-send-email-michael.chan@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1646470482-13763-1-git-send-email-michael.chan@broadcom.com> References: <1646470482-13763-1-git-send-email-michael.chan@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Kalesh AP FW returns error code "NVM_INSTALL_UPDATE_CMD_ERR_CODE_ANTI_ROLLBACK" in the response to indicate that HWRM_NVM_INSTALL_UPDATE command has failed due to Anti-rollback feature. Parse the error and return an appropriate error code to the user. Reviewed-by: Somnath Kotur Reviewed-by: Edwin Peer Signed-off-by: Kalesh AP Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index 59838a4f45fb..a3151af9a279 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -2609,6 +2609,10 @@ int bnxt_flash_package_from_fw_obj(struct net_device *dev, const struct firmware cmd_err = ((struct hwrm_err_output *)resp)->cmd_err; switch (cmd_err) { + case NVM_INSTALL_UPDATE_CMD_ERR_CODE_ANTI_ROLLBACK: + netdev_err(dev, "HWRM_NVM_INSTALL_UPDATE failure Anti-rollback detected\n"); + rc = -EALREADY; + break; case NVM_INSTALL_UPDATE_CMD_ERR_CODE_FRAG_ERR: install->flags = cpu_to_le16(NVM_INSTALL_UPDATE_REQ_FLAGS_ALLOWED_TO_DEFRAG);