| Message ID | 1646546192-32737-1-git-send-email-zheyuma97@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 69adcb988a0675ce001dfc416d56fba2e8a85f48 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] net: cxgb3: Fix an error code when probing the driver | expand |
On Sun, Mar 06, 2022 at 05:56:32AM +0000, Zheyu Ma wrote: > During the process of driver probing, probe function should return < 0 > for failure, otherwise kernel will treat value >= 0 as success. > > Therefore, the driver should set 'err' to -ENODEV when > 'adapter->registered_device_map' is NULL. Otherwise kernel will assume > that the driver has been successfully probed and will cause unexpected > errors. > > Signed-off-by: Zheyu Ma <zheyuma97@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Sun, 6 Mar 2022 05:56:32 +0000 you wrote: > During the process of driver probing, probe function should return < 0 > for failure, otherwise kernel will treat value >= 0 as success. > > Therefore, the driver should set 'err' to -ENODEV when > 'adapter->registered_device_map' is NULL. Otherwise kernel will assume > that the driver has been successfully probed and will cause unexpected > errors. > > [...] Here is the summary with links: - [v2] net: cxgb3: Fix an error code when probing the driver https://git.kernel.org/netdev/net-next/c/69adcb988a06 You are awesome, thank you!
diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c index bfffcaeee624..0d3325cf2107 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c @@ -3346,6 +3346,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) } if (!adapter->registered_device_map) { dev_err(&pdev->dev, "could not register any net devices\n"); + err = -ENODEV; goto out_free_dev; }
During the process of driver probing, probe function should return < 0 for failure, otherwise kernel will treat value >= 0 as success. Therefore, the driver should set 'err' to -ENODEV when 'adapter->registered_device_map' is NULL. Otherwise kernel will assume that the driver has been successfully probed and will cause unexpected errors. Signed-off-by: Zheyu Ma <zheyuma97@gmail.com> --- Changes in v2: - Change the error code --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 1 + 1 file changed, 1 insertion(+)