| Message ID | 164868907688.21983.1606862921419988152.stgit@devnote2 (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a2fb49833cad07a53651c23dce508127085fae2d |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf] rethook: Fix to use WRITE_ONCE() for rethook::handler | expand |
Hello: This patch was applied to bpf/bpf.git (master) by Alexei Starovoitov <ast@kernel.org>: On Thu, 31 Mar 2022 10:11:17 +0900 you wrote: > Since the function pointered by rethook::handler never be removed when > the rethook is alive, it doesn't need to use rcu_assign_pointer() to > update it. Just use WRITE_ONCE(). > > Reported-by: Alexei Starovoitov <alexei.starovoitov@gmail.com> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> > > [...] Here is the summary with links: - [bpf] rethook: Fix to use WRITE_ONCE() for rethook::handler https://git.kernel.org/bpf/bpf/c/a2fb49833cad You are awesome, thank you!
diff --git a/kernel/trace/rethook.c b/kernel/trace/rethook.c index ab463a4d2b23..b56833700d23 100644 --- a/kernel/trace/rethook.c +++ b/kernel/trace/rethook.c @@ -65,7 +65,7 @@ static void rethook_free_rcu(struct rcu_head *head) */ void rethook_free(struct rethook *rh) { - rcu_assign_pointer(rh->handler, NULL); + WRITE_ONCE(rh->handler, NULL); call_rcu(&rh->rcu, rethook_free_rcu); }
Since the function pointered by rethook::handler never be removed when the rethook is alive, it doesn't need to use rcu_assign_pointer() to update it. Just use WRITE_ONCE(). Reported-by: Alexei Starovoitov <alexei.starovoitov@gmail.com> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> --- kernel/trace/rethook.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)