| Message ID | 166260025920.81018.12730039389826735230.stgit@anambiarhost.jf.intel.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Extend action skbedit to RX queue mapping | expand |
Hi Amritha,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Amritha-Nambiar/Extend-action-skbedit-to-RX-queue-mapping/20220908-091523
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 2018b22a759e26a4c7e3ac6c60c283cfbd2c9c93
reproduce:
# https://github.com/intel-lab-lkp/linux/commit/1c8a93c17a4a1a9ba7be2aba8b1886d12ea14d8c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Amritha-Nambiar/Extend-action-skbedit-to-RX-queue-mapping/20220908-091523
git checkout 1c8a93c17a4a1a9ba7be2aba8b1886d12ea14d8c
make menuconfig
# enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS, CONFIG_WARN_ABI_ERRORS
make htmldocs
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> Documentation/networking/tc-queue-filters.rst:12: WARNING: Unexpected indentation.
>> Documentation/networking/tc-queue-filters.rst:14: WARNING: Block quote ends without a blank line; unexpected unindent.
>> Documentation/networking/tc-queue-filters.rst: WARNING: document isn't included in any toctree
vim +12 Documentation/networking/tc-queue-filters.rst
9
10 On the transmit side:
11 1. TC filter directing traffic to a set of queues is achieved
> 12 using the action skbedit priority for Tx priority selection,
13 the priority maps to a traffic class (set of queues).
> 14 2. TC filter directs traffic to a transmit queue with the action
15 skbedit queue_mapping $tx_qid.
16
diff --git a/Documentation/networking/tc-queue-filters.rst b/Documentation/networking/tc-queue-filters.rst new file mode 100644 index 000000000000..5839ddd23eb4 --- /dev/null +++ b/Documentation/networking/tc-queue-filters.rst @@ -0,0 +1,24 @@ +.. SPDX-License-Identifier: GPL-2.0 + +========================= +TC queue based filtering +========================= + +TC can be used for directing traffic to either a set of queues or +on a single queue on both the transmit and receive side. + +On the transmit side: +1. TC filter directing traffic to a set of queues is achieved + using the action skbedit priority for Tx priority selection, + the priority maps to a traffic class (set of queues). +2. TC filter directs traffic to a transmit queue with the action + skbedit queue_mapping $tx_qid. + +Likewise, on the receive side, the two filters for selecting set of +queues and/or a single queue is supported as below: +1. TC flower filter directs traffic to a set of queues using the + 'hw_tc' option of tc-flower. + hw_tc $TCID - Specify a hardware traffic class to pass matching + packets on to. TCID is in the range 0 through 15. +2. TC filter with action skbedit queue_mapping $rx_qid selects a + receive queue.
Added tc-queue-filters.rst with notes on TC filters for selecting a set of queues and/or a queue. Signed-off-by: Amritha Nambiar <amritha.nambiar@intel.com> --- Documentation/networking/tc-queue-filters.rst | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/networking/tc-queue-filters.rst