| Message ID | 1664520728-4644-1-git-send-email-zhangchangzhong@huawei.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] can: j1939: j1939_session_tx_eoma(): fix debug info | expand |
On Fri, Sep 30, 2022 at 02:52:08PM +0800, Zhang Changzhong wrote: > Use "%s" instead of "%p" to print function name in debug info. > > Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> Acked-by: Oleksij Rempel <o.rempel@pengutronix.de> Thank you! > --- > net/can/j1939/transport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/can/j1939/transport.c b/net/can/j1939/transport.c > index d7d86c9..6ec48a4 100644 > --- a/net/can/j1939/transport.c > +++ b/net/can/j1939/transport.c > @@ -985,7 +985,7 @@ static int j1939_session_tx_eoma(struct j1939_session *session) > /* wait for the EOMA packet to come in */ > j1939_tp_set_rxtimeout(session, 1250); > > - netdev_dbg(session->priv->ndev, "%p: 0x%p\n", __func__, session); > + netdev_dbg(session->priv->ndev, "%s: 0x%p\n", __func__, session); > > return 0; > } > -- > 2.9.5 > >
On 30.09.2022 14:52:08, Zhang Changzhong wrote: > Use "%s" instead of "%p" to print function name in debug info. > > Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> Applied to linux-can-next. Thanks, Marc
diff --git a/net/can/j1939/transport.c b/net/can/j1939/transport.c index d7d86c9..6ec48a4 100644 --- a/net/can/j1939/transport.c +++ b/net/can/j1939/transport.c @@ -985,7 +985,7 @@ static int j1939_session_tx_eoma(struct j1939_session *session) /* wait for the EOMA packet to come in */ j1939_tp_set_rxtimeout(session, 1250); - netdev_dbg(session->priv->ndev, "%p: 0x%p\n", __func__, session); + netdev_dbg(session->priv->ndev, "%s: 0x%p\n", __func__, session); return 0; }
Use "%s" instead of "%p" to print function name in debug info. Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> --- net/can/j1939/transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)