diff mbox series

net: macvlan: change schedule system_wq to system_unbound_wq

Message ID 1665646872-20954-1-git-send-email-zhangxiangqian@kylinos.cn (mailing list archive)
State Accepted
Commit 3d6642eac74d9442fde232181aa52d26d47991df
Delegated to: Netdev Maintainers
Headers show
Series net: macvlan: change schedule system_wq to system_unbound_wq | expand

Checks

Context Check Description
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

zhangxiangqian Oct. 13, 2022, 7:41 a.m. UTC
For FT2000+/64 devices,
when four virtual machines share the same physical network interface,
DROP will occur due to the single core CPU performance problem.

ip_check_defrag and macvlan_process_broadcast is on the same CPU.
When the MACVLAN PORT increases, the CPU usage reaches more than 90%.
bc_queue > bc_queue_len_used (default 1000), causing DROP.

Signed-off-by: zhangxiangqian <zhangxiangqian@kylinos.cn>
---
 drivers/net/macvlan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Oct. 14, 2022, 7:40 a.m. UTC | #1
Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Thu, 13 Oct 2022 15:41:12 +0800 you wrote:
> For FT2000+/64 devices,
> when four virtual machines share the same physical network interface,
> DROP will occur due to the single core CPU performance problem.
> 
> ip_check_defrag and macvlan_process_broadcast is on the same CPU.
> When the MACVLAN PORT increases, the CPU usage reaches more than 90%.
> bc_queue > bc_queue_len_used (default 1000), causing DROP.
> 
> [...]

Here is the summary with links:
  - net: macvlan: change schedule system_wq to system_unbound_wq
    https://git.kernel.org/netdev/net/c/3d6642eac74d

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 1080d6e..dd3f35e 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -361,7 +361,7 @@  static void macvlan_broadcast_enqueue(struct macvlan_port *port,
 	}
 	spin_unlock(&port->bc_queue.lock);
 
-	schedule_work(&port->bc_work);
+	queue_work(system_unbound_wq, &port->bc_work);
 
 	if (err)
 		goto free_nskb;