| Message ID | 1666315944-30898-1-git-send-email-zhangchangzhong@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9c1eaa27ec599fcc25ed4970c0b73c247d147a2b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: lantiq_etop: don't free skb when returning NETDEV_TX_BUSY | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 21 Oct 2022 09:32:24 +0800 you wrote: > The ndo_start_xmit() method must not free skb when returning > NETDEV_TX_BUSY, since caller is going to requeue freed skb. > > Fixes: 504d4721ee8e ("MIPS: Lantiq: Add ethernet driver") > Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> > --- > drivers/net/ethernet/lantiq_etop.c | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - [net] net: lantiq_etop: don't free skb when returning NETDEV_TX_BUSY https://git.kernel.org/netdev/net/c/9c1eaa27ec59 You are awesome, thank you!
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c index 59aab40..f5961bd 100644 --- a/drivers/net/ethernet/lantiq_etop.c +++ b/drivers/net/ethernet/lantiq_etop.c @@ -485,7 +485,6 @@ ltq_etop_tx(struct sk_buff *skb, struct net_device *dev) len = skb->len < ETH_ZLEN ? ETH_ZLEN : skb->len; if ((desc->ctl & (LTQ_DMA_OWN | LTQ_DMA_C)) || ch->skb[ch->dma.desc]) { - dev_kfree_skb_any(skb); netdev_err(dev, "tx ring full\n"); netif_tx_stop_queue(txq); return NETDEV_TX_BUSY;
The ndo_start_xmit() method must not free skb when returning NETDEV_TX_BUSY, since caller is going to requeue freed skb. Fixes: 504d4721ee8e ("MIPS: Lantiq: Add ethernet driver") Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> --- drivers/net/ethernet/lantiq_etop.c | 1 - 1 file changed, 1 deletion(-)