| Message ID | 16986d3d-7baf-4b02-a641-e2916d491264@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ef6249e37df5eac72bacdfe0a3000b08ae153146 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phy: clean up phy.h | expand |
On 2/13/2025 10:50 PM, Heiner Kallweit wrote: > phy_queue_state_machine() isn't used outside phy.c, > so stop exporting it. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/net/phy/phy.c | 4 ++-- > include/linux/phy.h | 1 - > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c > index d0c1718e2..8738ffb4c 100644 > --- a/drivers/net/phy/phy.c > +++ b/drivers/net/phy/phy.c > @@ -520,12 +520,12 @@ int __phy_hwtstamp_set(struct phy_device *phydev, > * @phydev: the phy_device struct > * @jiffies: Run the state machine after these jiffies > */ > -void phy_queue_state_machine(struct phy_device *phydev, unsigned long jiffies) > +static void phy_queue_state_machine(struct phy_device *phydev, > + unsigned long jiffies) > { > mod_delayed_work(system_power_efficient_wq, &phydev->state_queue, > jiffies); > } > -EXPORT_SYMBOL(phy_queue_state_machine); > > /** > * phy_trigger_machine - Trigger the state machine to run now > diff --git a/include/linux/phy.h b/include/linux/phy.h > index 33e2c2c93..bb7454364 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -2061,7 +2061,6 @@ int phy_drivers_register(struct phy_driver *new_driver, int n, > struct module *owner); > void phy_error(struct phy_device *phydev); > void phy_state_machine(struct work_struct *work); > -void phy_queue_state_machine(struct phy_device *phydev, unsigned long jiffies); > void phy_trigger_machine(struct phy_device *phydev); > void phy_mac_interrupt(struct phy_device *phydev); > void phy_start_machine(struct phy_device *phydev); Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
On Thu, Feb 13, 2025 at 10:50:02PM +0100, Heiner Kallweit wrote: > phy_queue_state_machine() isn't used outside phy.c, > so stop exporting it. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> My grep confirms. Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Thanks!
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index d0c1718e2..8738ffb4c 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -520,12 +520,12 @@ int __phy_hwtstamp_set(struct phy_device *phydev, * @phydev: the phy_device struct * @jiffies: Run the state machine after these jiffies */ -void phy_queue_state_machine(struct phy_device *phydev, unsigned long jiffies) +static void phy_queue_state_machine(struct phy_device *phydev, + unsigned long jiffies) { mod_delayed_work(system_power_efficient_wq, &phydev->state_queue, jiffies); } -EXPORT_SYMBOL(phy_queue_state_machine); /** * phy_trigger_machine - Trigger the state machine to run now diff --git a/include/linux/phy.h b/include/linux/phy.h index 33e2c2c93..bb7454364 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -2061,7 +2061,6 @@ int phy_drivers_register(struct phy_driver *new_driver, int n, struct module *owner); void phy_error(struct phy_device *phydev); void phy_state_machine(struct work_struct *work); -void phy_queue_state_machine(struct phy_device *phydev, unsigned long jiffies); void phy_trigger_machine(struct phy_device *phydev); void phy_mac_interrupt(struct phy_device *phydev); void phy_start_machine(struct phy_device *phydev);
phy_queue_state_machine() isn't used outside phy.c, so stop exporting it. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/phy/phy.c | 4 ++-- include/linux/phy.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-)